[GitHub] michael-o commented on a change in pull request #83: sonar: Use "Arrays.toString(array)" instead

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #83: sonar: Use "Arrays.toString(array)" instead
URL: https://github.com/apache/maven-scm/pull/83#discussion_r209740715
 
 

 ##########
 File path: maven-scm-providers/maven-scm-provider-integrity/src/main/java/org/apache/maven/scm/provider/integrity/command/blame/IntegrityBlameCommand.java
 ##########
 @@ -123,21 +123,24 @@ private BlameScmResult doShellAnnotate( IntegrityScmProviderRepository iRepo, Sc
         shell.createArg().setValue( "--fields=date,revision,author" );
         shell.createArg().setValue( '"' + filename + '"' );
         IntegrityBlameConsumer shellConsumer = new IntegrityBlameConsumer( getLogger() );
+        String commandLine = CommandLineUtils.toString( shell.getCommandline() );
 
         try
         {
-            getLogger().debug( "Executing: " + CommandLineUtils.toString( shell.getCommandline() ) );
+            if ( getLogger().isDebugEnabled() ) {
 
 Review comment:
   This isn't necessary anymore as soon as we use SLF4J.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services