You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2007/04/20 10:25:16 UTC
[jira] Commented: (HADOOP-1272) Extract InnerClasses from
FSNamesystem into separate classes
[ https://issues.apache.org/jira/browse/HADOOP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490261 ]
Tom White commented on HADOOP-1272:
-----------------------------------
This will also make the code clearer by breaking up the huge class into smaller chunks (FSNamesystem is over 4000 lines long!). The top ten:
find src/java/org/apache/hadoop -name *.java | xargs wc -l | sort -nr | head
68614 total
4277 src/java/org/apache/hadoop/dfs/FSNamesystem.java
2682 src/java/org/apache/hadoop/io/SequenceFile.java
1960 src/java/org/apache/hadoop/mapred/TaskTracker.java
1717 src/java/org/apache/hadoop/mapred/JobTracker.java
1440 src/java/org/apache/hadoop/dfs/DFSClient.java
1309 src/java/org/apache/hadoop/dfs/DataNode.java
1208 src/java/org/apache/hadoop/mapred/ReduceTask.java
1095 src/java/org/apache/hadoop/fs/FsShell.java
964 src/java/org/apache/hadoop/mapred/JobInProgress.java
> Extract InnerClasses from FSNamesystem into separate classes
> ------------------------------------------------------------
>
> Key: HADOOP-1272
> URL: https://issues.apache.org/jira/browse/HADOOP-1272
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: innerclasses.patch
>
>
> This will make the code cleaner. Also, it leads itself to a cleaner and easily understandable finer-grain locking model.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.