[Impala-ASF-CR] IMPALA-13115: Add query id to error messages

["Xuebin Su (Code Review)" <ge...@cloudera.org>]

Xuebin Su has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21587 )

Change subject: IMPALA-13115: Add query id to error messages
......................................................................

IMPALA-13115: Add query id to error messages

This patch adds the query id to the error messages in both

- the result of the get_log() RPC, and
- the error message in an RPC response

so that the users can easily figure out the errored queries on the
client side.

To achieve this, the query id in the thread debug info is set in the
RPC handler method, and is retrieved from the thread debug info every
time an error or log is returned to the client.

Due to the change of the error message format, some checks in the
impala-shell.py are adapted to keep them valid.

Testing:
- Added a helper function `error_msg_expected()` to check whether an
  error message is expected. It is stricter than only using the `in`
  operator.
- End-to-end test cases are adapted using `error_msg_expected()` to
  match the new error message format.
- `ImpalaBeeswaxException`, which is used in tests ONLY, is simplified
  so that its error message has the same format as the exceptions for
  HS2.
- Added an assertion to the case of killing and restarting a worker
  in the custom cluster test to ensure that the query id is in
  the error message in the client log retrieved with `get_log()`.

Change-Id: I67e659681e36162cad1d9684189106f8eedbf092
---
M be/src/service/child-query.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M shell/impala_shell.py
M testdata/workloads/functional-query/queries/QueryTest/acid-insert-fail.test
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M tests/beeswax/impala_beeswax.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_executor_groups.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_process_failures.py
M tests/custom_cluster/test_sys_db.py
M tests/metadata/test_stale_metadata.py
M tests/query_test/test_iceberg.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
21 files changed, 186 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/21587/4
-- 
To view, visit http://gerrit.cloudera.org:8080/21587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67e659681e36162cad1d9684189106f8eedbf092
Gerrit-Change-Number: 21587
Gerrit-PatchSet: 4
Gerrit-Owner: Xuebin Su <xs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>