You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jojo lalpin (JIRA)" <ji...@apache.org> on 2009/11/08 09:28:32 UTC

[jira] Created: (NET-298) Article numbers should be treated as LONG instead of INT in NNTP

Article numbers should be treated as LONG instead of INT in NNTP
----------------------------------------------------------------

                 Key: NET-298
                 URL: https://issues.apache.org/jira/browse/NET-298
             Project: Commons Net
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: jojo lalpin
            Priority: Minor


When getting list of newsgroups, articles number are beyond int limit :
here is server's reply about alt.binaries.boneless (one of the biggest of alt.binaries hierarchy) :

alt.binaries.boneless 2705422467 1662764743 y

As article number if often used, that's a lot of minor changes.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (NET-298) Article numbers should be treated as LONG instead of INT in NNTP

Posted by "jojo lalpin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774749#action_12774749 ] 

jojo lalpin edited comment on NET-298 at 11/8/09 10:34 AM:
-----------------------------------------------------------

Please find nntp files modified and a text file with all modifications done by file.

Modifications are : 
	Change variables related to article number and article count type from int to long
	Functions : 
		Integer.toString() in Long.toString()
		Integer.parseInt() in Long.parseLong()

Modified files are : 

	Article.java
	ArticlePointer.java
	NewsgroupInfo.java
	NNTP.java
	NNTPClient.java

It seems to work, at least newsgroup listing is ok now.





      was (Author: jojolalpin):
    Please find nntp files modified and a text file with all modifications done by file.

Modifications are : 
	Change variables related to article number and article count type from int to long
	Functions : 
		Integer.toString() in Long.toString()
		Integer.parseInt() in Long.parseLong()

Modified files are : 

	Article.java
	ArticlePointer.java
	NewsgroupInfo.java
	NNTP.java
	NNTPClient.java

I still  have not checked if this work but as I am a newbie in Java if it fails I won't go further (but I will tell it).
At least the text file give all locations where I think modifications should be done.




  
> Article numbers should be treated as LONG instead of INT in NNTP
> ----------------------------------------------------------------
>
>                 Key: NET-298
>                 URL: https://issues.apache.org/jira/browse/NET-298
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: jojo lalpin
>            Priority: Minor
>         Attachments: nntp_modifications.zip
>
>
> When getting list of newsgroups, articles number are beyond int limit :
> here is server's reply about alt.binaries.boneless (one of the biggest of alt.binaries hierarchy) :
> alt.binaries.boneless 2705422467 1662764743 y
> As article number if often used, that's a lot of minor changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (NET-298) Article numbers should be treated as LONG instead of INT in NNTP

Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rory Winston closed NET-298.
----------------------------

       Resolution: Fixed
    Fix Version/s: Nightly Builds

fixed in svn

> Article numbers should be treated as LONG instead of INT in NNTP
> ----------------------------------------------------------------
>
>                 Key: NET-298
>                 URL: https://issues.apache.org/jira/browse/NET-298
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: jojo lalpin
>            Priority: Minor
>             Fix For: Nightly Builds
>
>         Attachments: nntp_modifications.zip
>
>
> When getting list of newsgroups, articles number are beyond int limit :
> here is server's reply about alt.binaries.boneless (one of the biggest of alt.binaries hierarchy) :
> alt.binaries.boneless 2705422467 1662764743 y
> As article number if often used, that's a lot of minor changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (NET-298) Article numbers should be treated as LONG instead of INT in NNTP

Posted by "jojo lalpin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jojo lalpin updated NET-298:
----------------------------

    Attachment: nntp_modifications.zip

Please find nntp files modified and a text file with all modifications done by file.

Modifications are : 
	Change variables related to article number and article count type from int to long
	Functions : 
		Integer.toString() in Long.toString()
		Integer.parseInt() in Long.parseLong()

Modified files are : 

	Article.java
	ArticlePointer.java
	NewsgroupInfo.java
	NNTP.java
	NNTPClient.java

I still  have not checked if this work but as I am a newbie in Java if it fails I won't go further (but I will tell it).
At least the text file give all locations where I think modifications should be done.





> Article numbers should be treated as LONG instead of INT in NNTP
> ----------------------------------------------------------------
>
>                 Key: NET-298
>                 URL: https://issues.apache.org/jira/browse/NET-298
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: jojo lalpin
>            Priority: Minor
>         Attachments: nntp_modifications.zip
>
>
> When getting list of newsgroups, articles number are beyond int limit :
> here is server's reply about alt.binaries.boneless (one of the biggest of alt.binaries hierarchy) :
> alt.binaries.boneless 2705422467 1662764743 y
> As article number if often used, that's a lot of minor changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-298) Article numbers should be treated as LONG instead of INT in NNTP

Posted by "Grégory Joseph (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884648#action_12884648 ] 

Grégory Joseph commented on NET-298:
------------------------------------

NET-276 fixed a couple of those issues for 2.1, but there are still some problems with 2.1: client.selectArticle() for example, still takes an int parameter; I understand that this issue here hopefully fixed the rest of it - any chance of this getting pushed as a release any time soon ?

> Article numbers should be treated as LONG instead of INT in NNTP
> ----------------------------------------------------------------
>
>                 Key: NET-298
>                 URL: https://issues.apache.org/jira/browse/NET-298
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: jojo lalpin
>            Priority: Minor
>             Fix For: Nightly Builds
>
>         Attachments: nntp_modifications.zip
>
>
> When getting list of newsgroups, articles number are beyond int limit :
> here is server's reply about alt.binaries.boneless (one of the biggest of alt.binaries hierarchy) :
> alt.binaries.boneless 2705422467 1662764743 y
> As article number if often used, that's a lot of minor changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.