[GitHub] [flink] luoyuxia commented on a diff in pull request #17990: [FLINK-25142][Connectors / Hive]Fix user-defined hive udtf initialize exception in hive dialect

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #17990:
URL: https://github.com/apache/flink/pull/17990#discussion_r844926008


##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java:
##########
@@ -665,6 +667,62 @@ public void testTemporaryFunctionUDAF() throws Exception {
         tableEnv.executeSql("drop temporary function if exists foo");
     }
 
+    @Test
+    public void testTemporaryFunctionUDTFInitializeWithObjectInspector() throws Exception {

Review Comment:
   @xiangqiao123 Sorry to go back to it again. 
   But Could you please merge the test code/logic in `testTemporaryFunctionUDTFInitializeWithObjectInspector` and `testTemporaryFunctionUDTFInitializeWithStructObjectInspector` to one method, so that the code base for the test won't grow rapidly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org