You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/08/30 18:31:47 UTC

[GitHub] jai1 opened a new pull request #730: CPP Client: Deprecated few APIs that can't be used with batch messages

jai1 opened a new pull request #730: CPP Client: Deprecated few APIs that can't be used with batch messages
URL: https://github.com/apache/incubator-pulsar/pull/730
 
 
   Since we don't have the pimpl trick in MessageId we resorted to using inheritance for BatchMessageId. Due to object slicing we have no guarantee that the MessageId that the user provides can be typecasted to BatchMessageId (i.e we may lose the batch index information). Like for example if a person is using a vector to keep track of messageId and then calling these methods.
   
   @merlimat  and @msb-at-yahoo - your inputs will be valuable
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services