You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2023/11/26 21:47:54 UTC
[PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
michael-o opened a new pull request, #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253
…oupId:artifactId, but different versions
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "ao-apps (via GitHub)" <gi...@apache.org>.
ao-apps commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834301033
I have created integration tests for MJAVADOC-682: https://github.com/apache/maven-javadoc-plugin/commit/2f291d40e672078e042bfc11241dd90aefc04450
Should I create a separate pull request, of you can merge this commit into your MJAVADOC-682 branch?
Thank you,
- Dan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834535266
> Should I change the commit message to begin with "[[MJAVADOC-682](https://issues.apache.org/jira/browse/MJAVADOC-682)]"?
No, I will squash anyway and give you attributions, of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #253: [MJAVADOC-682] Reactor builds fail when multiple modules with same gr…
URL: https://github.com/apache/maven-javadoc-plugin/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-2957397443
Resolve #1064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834546577
> > CI is rolling...
>
> I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files.
Modified...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "ao-apps (via GitHub)" <gi...@apache.org>.
ao-apps commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834421972
Should I change the commit message to begin with "[MJAVADOC-682]"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "ao-apps (via GitHub)" <gi...@apache.org>.
ao-apps commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834560911
I went ahead and confirmed the provided integration tests for MJAVADOC-682 do, in fact, reproduce the originally reported issue: The build succeeds on 3.0.1 and fails on 3.6.2 as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834409990
> I have created integration tests for [MJAVADOC-682](https://issues.apache.org/jira/browse/MJAVADOC-682): [2f291d4](https://github.com/apache/maven-javadoc-plugin/commit/2f291d40e672078e042bfc11241dd90aefc04450)
>
> Should I create a separate pull request, or you can merge this commit into your [MJAVADOC-682](https://issues.apache.org/jira/browse/MJAVADOC-682) branch?
>
> Thank you,
>
> * Dan
I will intergrate from here: https://github.com/ao-apps/maven-javadoc-plugin/tree/MJAVADOC-682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834541330
CI is rolling...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]
Posted by "ao-apps (via GitHub)" <gi...@apache.org>.
ao-apps commented on PR #253:
URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834544596
> CI is rolling...
I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org