You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2015/02/02 23:54:15 UTC

[5/5] qpid-jms git commit: More code coverage testing.

More code coverage testing. 

Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/251ff03b
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/251ff03b
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/251ff03b

Branch: refs/heads/master
Commit: 251ff03b08cbc2e3a83f04737a989eb4e23dbb8b
Parents: dd57a72
Author: Timothy Bish <ta...@gmail.com>
Authored: Mon Feb 2 17:53:58 2015 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Mon Feb 2 17:53:58 2015 -0500

----------------------------------------------------------------------
 .../jms/producer/JmsMessageProducerTest.java    | 93 +++++++++++++++++++-
 1 file changed, 90 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/251ff03b/qpid-jms-client/src/test/java/org/apache/qpid/jms/producer/JmsMessageProducerTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/producer/JmsMessageProducerTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/producer/JmsMessageProducerTest.java
index 120c24d..c415932 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/producer/JmsMessageProducerTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/producer/JmsMessageProducerTest.java
@@ -16,8 +16,13 @@
  */
 package org.apache.qpid.jms.producer;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
+import javax.jms.DeliveryMode;
 import javax.jms.InvalidDestinationException;
 import javax.jms.Message;
 import javax.jms.MessageProducer;
@@ -25,8 +30,10 @@ import javax.jms.Session;
 
 import org.apache.qpid.jms.JmsConnectionTestSupport;
 import org.apache.qpid.jms.JmsDestination;
+import org.apache.qpid.jms.JmsMessageProducer;
 import org.apache.qpid.jms.JmsQueue;
 import org.apache.qpid.jms.JmsSession;
+import org.apache.qpid.jms.JmsTopic;
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mockito;
@@ -38,6 +45,9 @@ public class JmsMessageProducerTest extends JmsConnectionTestSupport {
 
     private JmsSession session;
 
+    private final JmsTopic topic = new JmsTopic("topic");
+    private final JmsQueue queue = new JmsQueue("topic");
+
     @Override
     @Before
     public void setUp() throws Exception {
@@ -46,7 +56,84 @@ public class JmsMessageProducerTest extends JmsConnectionTestSupport {
         session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
     }
 
-    @Test
+    @Test(timeout = 10000)
+    public void testMultipleCloseCallsNoErrors() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        producer.close();
+        producer.close();
+    }
+
+    @Test(timeout = 10000, expected = InvalidDestinationException.class)
+    public void testSetDestinationToNull() throws Exception {
+        JmsMessageProducer producer = (JmsMessageProducer) session.createProducer(null);
+        producer.setDestination(null);
+    }
+
+    @Test(timeout = 10000)
+    public void testSetDestinationToCurrentValue() throws Exception {
+        JmsMessageProducer producer = (JmsMessageProducer) session.createProducer(queue);
+        producer.setDestination(queue);
+    }
+
+    @Test(timeout = 10000, expected = UnsupportedOperationException.class)
+    public void testSetDesinationOnNonAnonymousProducer() throws Exception {
+        JmsMessageProducer producer = (JmsMessageProducer) session.createProducer(queue);
+        producer.setDestination(topic);
+    }
+
+    @Test(timeout = 10000, expected = UnsupportedOperationException.class)
+    public void testSetDesinationOnAnonymousProducer() throws Exception {
+        JmsMessageProducer producer = (JmsMessageProducer) session.createProducer(null);
+        producer.setDestination(topic);
+    }
+
+    @Test(timeout = 10000)
+    public void testCreateProducerWithNullDestination() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        assertNull(producer.getDestination());
+    }
+
+    @Test(timeout = 10000)
+    public void testGetDisableMessageID() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        assertFalse(producer.getDisableMessageID());
+        producer.setDisableMessageID(true);
+        assertTrue(producer.getDisableMessageID());
+    }
+
+    @Test(timeout = 10000)
+    public void testGetDisableTimeStamp() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        assertFalse(producer.getDisableMessageTimestamp());
+        producer.setDisableMessageTimestamp(true);
+        assertTrue(producer.getDisableMessageTimestamp());
+    }
+
+    @Test(timeout = 10000)
+    public void testPriorityConfiguration() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        assertEquals(Message.DEFAULT_PRIORITY, producer.getPriority());
+        producer.setPriority(9);
+        assertEquals(9, producer.getPriority());
+    }
+
+    @Test(timeout = 10000)
+    public void testTimeToLiveConfiguration() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        assertEquals(Message.DEFAULT_TIME_TO_LIVE, producer.getTimeToLive());
+        producer.setTimeToLive(1000);
+        assertEquals(1000, producer.getTimeToLive());
+    }
+
+    @Test(timeout = 10000)
+    public void testDeliveryModeConfiguration() throws Exception {
+        MessageProducer producer = session.createProducer(null);
+        assertEquals(Message.DEFAULT_DELIVERY_MODE, producer.getDeliveryMode());
+        producer.setDeliveryMode(DeliveryMode.NON_PERSISTENT);
+        assertEquals(DeliveryMode.NON_PERSISTENT, producer.getDeliveryMode());
+    }
+
+    @Test(timeout = 10000)
     public void testAnonymousProducerThrowsUOEWhenExplictDestinationNotProvided() throws Exception {
         MessageProducer producer = session.createProducer(null);
 
@@ -66,7 +153,7 @@ public class JmsMessageProducerTest extends JmsConnectionTestSupport {
         }
     }
 
-    @Test
+    @Test(timeout = 10000)
     public void testExplicitProducerThrowsUOEWhenExplictDestinationIsProvided() throws Exception {
         JmsDestination dest = new JmsQueue("explicitDestination");
         MessageProducer producer = session.createProducer(new JmsQueue());
@@ -87,7 +174,7 @@ public class JmsMessageProducerTest extends JmsConnectionTestSupport {
         }
     }
 
-    @Test
+    @Test(timeout = 10000)
     public void testAnonymousDestinationProducerThrowsIDEWhenNullDestinationIsProvided() throws Exception {
         MessageProducer producer = session.createProducer(null);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org