You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/06/08 03:02:14 UTC

Review Request 35196: Views : NPE accessing view that includes velocity.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35196/
-----------------------------------------------------------

Review request for Ambari and Robert Levas.


Bugs: AMBARI-11774
    https://issues.apache.org/jira/browse/AMBARI-11774


Repository: ambari


Description
-------

Intermittent issue accessing a view that includes a version of the Velocity jar in its archive. Shows up as an NPE in the Velocity initialization code.
Related to class loader conflict with the Velocity classes included with Ambari.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java c90bcaa 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java f831989 

Diff: https://reviews.apache.org/r/35196/diff/


Testing
-------

Manual tested.

Updated unit tests.

mvn clean test

all tests pass.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50:04 min
[INFO] Finished at: 2015-06-07T20:41:41-04:00
[INFO] Final Memory: 56M/1586M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Re: Review Request 35196: Views : NPE accessing view that includes velocity.

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35196/#review86977
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On June 7, 2015, 9:02 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35196/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 9:02 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-11774
>     https://issues.apache.org/jira/browse/AMBARI-11774
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Intermittent issue accessing a view that includes a version of the Velocity jar in its archive. Shows up as an NPE in the Velocity initialization code.
> Related to class loader conflict with the Velocity classes included with Ambari.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java c90bcaa 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java f831989 
> 
> Diff: https://reviews.apache.org/r/35196/diff/
> 
> 
> Testing
> -------
> 
> Manual tested.
> 
> Updated unit tests.
> 
> mvn clean test
> 
> all tests pass.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:04 min
> [INFO] Finished at: 2015-06-07T20:41:41-04:00
> [INFO] Final Memory: 56M/1586M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>