You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:36:41 UTC
[GitHub] [phoenix] kadirozde opened a new pull request #846: PHOENIX-6045 Delete that should qualify for index path does not use i…
kadirozde opened a new pull request #846:
URL: https://github.com/apache/phoenix/pull/846
…ndex when multiple indexes are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde merged pull request #846: PHOENIX-6045 Delete that should qualify for index path does not use i…
Posted by GitBox <gi...@apache.org>.
kadirozde merged pull request #846:
URL: https://github.com/apache/phoenix/pull/846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #846: PHOENIX-6045 Delete that should qualify for index path does not use i…
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #846:
URL: https://github.com/apache/phoenix/pull/846#discussion_r461777313
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java
##########
@@ -486,19 +494,22 @@ else if (table.isTransactional() && connection.getSCN() != null) {
projectedColumns.add(column);
aliasedNodes.add(FACTORY.aliasedNode(null, FACTORY.column(null, '"' + column.getName().getString() + '"', null)));
}
- // Project all non PK indexed columns so that we can do the proper index maintenance
+ // Project all non PK indexed columns so that we can do the proper index maintenance on the indexes for which
+ // mutations are generated on the client side. Indexed columns are needed to identify index rows to be deleted
for (PTable index : table.getIndexes()) {
Review comment:
Possibly but I have tested this code and do not want to go through the whole testing cycle which includes testing on a real cluster as this is a production issue for us now. Thanks for the suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] comnetwork commented on a change in pull request #846: PHOENIX-6045 Delete that should qualify for index path does not use i…
Posted by GitBox <gi...@apache.org>.
comnetwork commented on a change in pull request #846:
URL: https://github.com/apache/phoenix/pull/846#discussion_r461525087
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java
##########
@@ -486,19 +494,22 @@ else if (table.isTransactional() && connection.getSCN() != null) {
projectedColumns.add(column);
aliasedNodes.add(FACTORY.aliasedNode(null, FACTORY.column(null, '"' + column.getName().getString() + '"', null)));
}
- // Project all non PK indexed columns so that we can do the proper index maintenance
+ // Project all non PK indexed columns so that we can do the proper index maintenance on the indexes for which
+ // mutations are generated on the client side. Indexed columns are needed to identify index rows to be deleted
for (PTable index : table.getIndexes()) {
Review comment:
Perhaps use `clientSideIndexes` here is better?
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java
##########
@@ -486,19 +494,22 @@ else if (table.isTransactional() && connection.getSCN() != null) {
projectedColumns.add(column);
aliasedNodes.add(FACTORY.aliasedNode(null, FACTORY.column(null, '"' + column.getName().getString() + '"', null)));
}
- // Project all non PK indexed columns so that we can do the proper index maintenance
+ // Project all non PK indexed columns so that we can do the proper index maintenance on the indexes for which
+ // mutations are generated on the client side. Indexed columns are needed to identify index rows to be deleted
for (PTable index : table.getIndexes()) {
Review comment:
Perhaps use `clientSideIndexes` instead checking` isMaintainedOnClient` here is better?
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java
##########
@@ -486,19 +494,22 @@ else if (table.isTransactional() && connection.getSCN() != null) {
projectedColumns.add(column);
aliasedNodes.add(FACTORY.aliasedNode(null, FACTORY.column(null, '"' + column.getName().getString() + '"', null)));
}
- // Project all non PK indexed columns so that we can do the proper index maintenance
+ // Project all non PK indexed columns so that we can do the proper index maintenance on the indexes for which
+ // mutations are generated on the client side. Indexed columns are needed to identify index rows to be deleted
for (PTable index : table.getIndexes()) {
Review comment:
Perhaps use `clientSideIndexes` instead of checking` isMaintainedOnClient` here is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on pull request #846: PHOENIX-6045 Delete that should qualify for index path does not use i…
Posted by GitBox <gi...@apache.org>.
dbwong commented on pull request #846:
URL: https://github.com/apache/phoenix/pull/846#issuecomment-664690049
FYI @lhofhansl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org