You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/12/18 05:34:18 UTC

[jira] Created: (HBASE-2054) memstore size 0 is >= than blocking -2.0g size

memstore size 0 is >= than blocking -2.0g size
----------------------------------------------

                 Key: HBASE-2054
                 URL: https://issues.apache.org/jira/browse/HBASE-2054
             Project: Hadoop HBase
          Issue Type: Bug
    Affects Versions: 0.20.2
            Reporter: Jean-Daniel Cryans
            Assignee: Jean-Daniel Cryans
             Fix For: 0.20.3, 0.21.0


On scoundrel's cluster, I made him set his MemStore size at 256MB and hbase.hregion.memstore.block.multiplier to 8 and it seems that it overruns the integer so we get stuff like :

{code}
2009-12-17 21:52:34,314 INFO org.apache.hadoop.hbase.regionserver.HRegion: Blocking updates for 'IPC Server handler 79 on 60020' on region text_storage,,1261107769109: memstore size 0 is >= than blocking -2.0g size
2009-12-17 21:52:44,317 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
2009-12-17 21:52:54,320 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
2009-12-17 21:53:04,323 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
2009-12-17 21:53:14,325 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
...
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2054) memstore size 0 is >= than blocking -2.0g size

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-2054:
--------------------------------------

    Attachment: HBASE-2054.patch

Changes ints to longs for memstore-related HRegion variables. Running the tests.

> memstore size 0 is >= than blocking -2.0g size
> ----------------------------------------------
>
>                 Key: HBASE-2054
>                 URL: https://issues.apache.org/jira/browse/HBASE-2054
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.3, 0.21.0
>
>         Attachments: HBASE-2054.patch
>
>
> On scoundrel's cluster, I made him set his MemStore size at 256MB and hbase.hregion.memstore.block.multiplier to 8 and it seems that it overruns the integer so we get stuff like :
> {code}
> 2009-12-17 21:52:34,314 INFO org.apache.hadoop.hbase.regionserver.HRegion: Blocking updates for 'IPC Server handler 79 on 60020' on region text_storage,,1261107769109: memstore size 0 is >= than blocking -2.0g size
> 2009-12-17 21:52:44,317 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:52:54,320 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:04,323 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:14,325 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-2054) memstore size 0 is >= than blocking -2.0g size

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved HBASE-2054.
---------------------------------------

    Resolution: Fixed

Committed to branch and trunk.

> memstore size 0 is >= than blocking -2.0g size
> ----------------------------------------------
>
>                 Key: HBASE-2054
>                 URL: https://issues.apache.org/jira/browse/HBASE-2054
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.3, 0.21.0
>
>         Attachments: HBASE-2054.patch
>
>
> On scoundrel's cluster, I made him set his MemStore size at 256MB and hbase.hregion.memstore.block.multiplier to 8 and it seems that it overruns the integer so we get stuff like :
> {code}
> 2009-12-17 21:52:34,314 INFO org.apache.hadoop.hbase.regionserver.HRegion: Blocking updates for 'IPC Server handler 79 on 60020' on region text_storage,,1261107769109: memstore size 0 is >= than blocking -2.0g size
> 2009-12-17 21:52:44,317 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:52:54,320 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:04,323 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:14,325 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2054) memstore size 0 is >= than blocking -2.0g size

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792678#action_12792678 ] 

Jean-Daniel Cryans commented on HBASE-2054:
-------------------------------------------

All the tests pass except for TestHeapSize which I then fixed. I will commit in branch and trunk unless objections.

> memstore size 0 is >= than blocking -2.0g size
> ----------------------------------------------
>
>                 Key: HBASE-2054
>                 URL: https://issues.apache.org/jira/browse/HBASE-2054
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.3, 0.21.0
>
>         Attachments: HBASE-2054.patch
>
>
> On scoundrel's cluster, I made him set his MemStore size at 256MB and hbase.hregion.memstore.block.multiplier to 8 and it seems that it overruns the integer so we get stuff like :
> {code}
> 2009-12-17 21:52:34,314 INFO org.apache.hadoop.hbase.regionserver.HRegion: Blocking updates for 'IPC Server handler 79 on 60020' on region text_storage,,1261107769109: memstore size 0 is >= than blocking -2.0g size
> 2009-12-17 21:52:44,317 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:52:54,320 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:04,323 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:14,325 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2054) memstore size 0 is >= than blocking -2.0g size

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793032#action_12793032 ] 

Jean-Daniel Cryans commented on HBASE-2054:
-------------------------------------------

dodger on IRC saw that I forgot the change the setter of the memstore size so I committed a fix:
{code}
-  public void setMemStoreFlushSize(int memstoreFlushSize) {
+  public void setMemStoreFlushSize(long memstoreFlushSize) {
     setValue(MEMSTORE_FLUSHSIZE_KEY,
-      Bytes.toBytes(Integer.toString(memstoreFlushSize)));
+      Bytes.toBytes(Long.toString(memstoreFlushSize)));
{code}

And to UnmodifyableHTableDescriptor.java:

{code}
-   * @see org.apache.hadoop.hbase.HTableDescriptor#setMemStoreFlushSize(int)
+   * @see org.apache.hadoop.hbase.HTableDescriptor#setMemStoreFlushSize(long)
    */
   @Override
-  public void setMemStoreFlushSize(int memstoreFlushSize) {
+  public void setMemStoreFlushSize(long memstoreFlushSize) {
     throw new UnsupportedOperationException("HTableDescriptor is read-only");
{code}

> memstore size 0 is >= than blocking -2.0g size
> ----------------------------------------------
>
>                 Key: HBASE-2054
>                 URL: https://issues.apache.org/jira/browse/HBASE-2054
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.3, 0.21.0
>
>         Attachments: HBASE-2054.patch
>
>
> On scoundrel's cluster, I made him set his MemStore size at 256MB and hbase.hregion.memstore.block.multiplier to 8 and it seems that it overruns the integer so we get stuff like :
> {code}
> 2009-12-17 21:52:34,314 INFO org.apache.hadoop.hbase.regionserver.HRegion: Blocking updates for 'IPC Server handler 79 on 60020' on region text_storage,,1261107769109: memstore size 0 is >= than blocking -2.0g size
> 2009-12-17 21:52:44,317 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:52:54,320 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:04,323 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> 2009-12-17 21:53:14,325 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush requested on text_storage,,1261107769109
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.