You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "moistbeans23 (via GitHub)" <gi...@apache.org> on 2024/07/23 20:52:42 UTC
[PR] SOLR-17285: Move RemoteSolrException to SolrClient in v10 [solr]
moistbeans23 opened a new pull request, #2587:
URL: https://github.com/apache/solr/pull/2587
https://issues.apache.org/jira/browse/SOLR-17285
# Description
Moved RemoteSolrException to SolrClient from BaseHttpSolrClient
# Solution
Moved RemoteSolrException class to SolrClient. Manually changed import statements from BaseHttpSolrClient to SolrClient if is not needed anymore for RemoteSolrException. Changed BaseHttpSolrClient.RemoteSolrException to SolrClient.RemoteSolrException
# Tests
[OUTPUT-org.apache.solr.cloud.HttpPartitionOnCommitTest.txt](https://github.com/user-attachments/files/16354132/OUTPUT-org.apache.solr.cloud.HttpPartitionOnCommitTest.txt)
[OUTPUT-org.apache.solr.cloud.ReplaceNodeTest.txt](https://github.com/user-attachments/files/16354138/OUTPUT-org.apache.solr.cloud.ReplaceNodeTest.txt)
[OUTPUT-org.apache.solr.handler.TestSolrConfigHandlerConcurrent.txt](https://github.com/user-attachments/files/16354141/OUTPUT-org.apache.solr.handler.TestSolrConfigHandlerConcurrent.txt)
[OUTPUT-org.apache.solr.pkg.TestPackages.txt](https://github.com/user-attachments/files/16354145/OUTPUT-org.apache.solr.pkg.TestPackages.txt)
I ran ./gradlew dev. It worked fine
`./gradlew check` did not work. It said there were failing tests on unrelated files
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17285: Move RemoteSolrException to SolrClient in v10 [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2587:
URL: https://github.com/apache/solr/pull/2587#issuecomment-2369965706
@samuelrivascoding how shall I credit you (name you) in CHANGES.txt? If I don't hear back, it'll be literally _that_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17285: Move RemoteSolrException to SolrClient in v10 [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2587:
URL: https://github.com/apache/solr/pull/2587#issuecomment-2381004621
Will merge as soon as Monday. I also plan to handle RemoteSolrException in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17285: Move RemoteSolrException to SolrClient in v10 [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2587:
URL: https://github.com/apache/solr/pull/2587#issuecomment-2246403844
I am looking at BaseHttpSolrClient again, and I see that RemoteExecutionException is *also* something that'll need to be moved. It's not used in many places. I think it's reasonable to include that in the scope of this JIRA issue and PR; WDYT? But I don't love the name "RemoteExecutionException" and I'm not even convinced it needs to exist; like couldn't RemoteSolrException take a payload? Publishing it to SolrClient would give it undeserved visibility IMO. Hmmm. On the other hand, based on how it's used, this is so internal that maybe it should simply move to HttpSolrClientBase (which is the successor to BaseHttpSolrClient). I welcome your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17285: Move RemoteSolrException to SolrClient in v10 [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2587:
URL: https://github.com/apache/solr/pull/2587#issuecomment-2365367073
This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org