[jira] [Resolved] (AMQCPP-598) CmsTemplate::createConsumer possible dereference of null pointer

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQCPP-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQCPP-598.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 3.9.4

Patch applied, this should never actually happen but an extra check doesn't hurt.  

> CmsTemplate::createConsumer possible dereference of null pointer
> ----------------------------------------------------------------
>
>                 Key: AMQCPP-598
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-598
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: CMS Impl
>            Reporter: Daniel L. Robertson
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 3.9.4
>
>         Attachments: CmsTemplate.cpp.patch
>
>
> If `CMSTemplate::takeSession()` returns NULL in `CMSTemplate::execute`, it is dereferenced in `CmsTemplate::createConsumer`. As far as I could tell, this is a plausible scenario, but I could be wrong. It looks like `ProducerExecutor::doInCms` checks for a NULL session, but `ReceiveExecutor::doInCms` does not. If this is because it is known that the session cannot be NULL, please close this issue. It just looked a bit off to me.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)