[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #66: Properly support SBT 1.8.2 and Scala 3

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-grpc/pull/66#discussion_r1208112432


##########
codegen/src/main/scala/org/apache/pekko/grpc/gen/scaladsl/Serializer.scala:
##########
@@ -16,7 +16,7 @@ package org.apache.pekko.grpc.gen.scaladsl
 import com.google.protobuf.Descriptors.{ Descriptor, MethodDescriptor }
 import scalapb.compiler.DescriptorImplicits
 
-case class Serializer(name: String, init: String)
+case class Serializer(name: String, scalaType: String, init: String)

Review Comment:
   This change is necessary in order to provide an explicit type to `implicit val` definitions (which are mandatory in Scala 3). Note that this isn't really a public class since its part of pekko-grpc's codegen, in other words no one should be depending on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org