You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/09 13:18:43 UTC
[GitHub] [superset] zhouyao1994 opened a new issue, #21028: Format the same size of picture for better part of "Supported Databases" document.
zhouyao1994 opened a new issue, #21028:
URL: https://github.com/apache/superset/issues/21028
## [SIP-88] Proposal for Better part of "Supported Databases" document
### Motivation
I'm learning how to use Photoshop. At same time ,I think the Part of "Supported Databases" in README’s picture is not align better. Since the picture of logos is not the some size.
I think we can learn from the part of "who is using Kylin" of [Apache Kylin](https://kylin.apache.org/)‘s website,that is more beauty,
[the keylin website]
<img width="512" alt="image" src="https://user-images.githubusercontent.com/5468589/183650282-8c3d2455-1647-4679-af12-5ee6eb429470.png">
[the superset readme]
<img width="512" alt="image" src="https://user-images.githubusercontent.com/5468589/183655634-48a727ac-e15a-4722-874e-2851dfbee28b.png">
So I porpose this SIP to improve document better.
We can format the logo in the same format at the some size (for example,png, 400*160)
If accept, May be i can help.😁
### Proposed Change
No code change ,Just pictures and Readme file
format the logo in the same format at the some size . type:png size:400*160
### New or Changed Public Interfaces
no change
### New dependencies
no change
### Migration Plan and Compatibility
no change
### Rejected Alternatives
other format, 200* 80 or something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on issue #21028: Format the same size of picture for better part of "Supported Databases" document.
Posted by GitBox <gi...@apache.org>.
srinify commented on issue #21028:
URL: https://github.com/apache/superset/issues/21028#issuecomment-1209634575
Hey @zhouyao1994 agreed! This doesn't need a SIP, which is reserved for major / controversial changes that require lots of discussions.
Feel free to open a PR with improvements :)
https://preset.io/blog/tutorial-contributing-code-to-apache-superset/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Format the same size of picture for better part of "Supported Databases" document. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #21028:
URL: https://github.com/apache/superset/issues/21028#issuecomment-1936458094
Looks like this should have been closed by the PR. Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Format the same size of picture for better part of "Supported Databases" document. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #21028: Format the same size of picture for better part of "Supported Databases" document.
URL: https://github.com/apache/superset/issues/21028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org