[GitHub] [accumulo] milleruntime commented on a change in pull request #2414: Fix issues in MiniAccumuloCluster.verifyUp that is causing tests to fail

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2414:
URL: https://github.com/apache/accumulo/pull/2414#discussion_r792643306



##########
File path: minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
##########
@@ -608,6 +618,8 @@ public synchronized void start() throws IOException, InterruptedException {
 
   private void verifyUp() throws InterruptedException, IOException {
 
+    int numTries = 10;
+
     requireNonNull(getClusterControl().managerProcess, "Error starting Manager - no process");
     requireNonNull(getClusterControl().managerProcess.info().startInstant().get(),

Review comment:
       I am not sure this error message will get thrown. If you look at the impl of `Optional.get()` it will throw its own exception:
   <pre>
    public T get() {
           if (value == null) {
               throw new NoSuchElementException("No value present");
           }
           return value;
       }
   </pre>




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org