You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/24 21:52:27 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
dongjoon-hyun opened a new pull request, #36984:
URL: https://github.com/apache/spark/pull/36984
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36984:
URL: https://github.com/apache/spark/pull/36984#issuecomment-1167721183
Thank you so much, @viirya .
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36984:
URL: https://github.com/apache/spark/pull/36984#issuecomment-1166210340
I made a PR to fix master branch
- https://github.com/apache/spark/pull/36987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36984:
URL: https://github.com/apache/spark/pull/36984#issuecomment-1167484757
Could you review this please, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36984:
URL: https://github.com/apache/spark/pull/36984#discussion_r906612721
##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -79,7 +79,7 @@ private[spark] class NettyBlockTransferService(
server = createServer(serverBootstrap.toList)
appId = conf.getAppId
- logger.info(s"Server created on $hostName:${server.getPort}")
+ logger.info(s"Server created on $hostName $bindAddress:${server.getPort}")
Review Comment:
`hostName` could be different from `bindAddress`.
```
NettyBlockTransferService: Server created on otherHost localhost:54718
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36984:
URL: https://github.com/apache/spark/pull/36984#discussion_r906614719
##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -79,7 +79,11 @@ private[spark] class NettyBlockTransferService(
server = createServer(serverBootstrap.toList)
appId = conf.getAppId
- logger.info(s"Server created on $hostName:${server.getPort}")
+ if (hostName.equals(bindAddress)) {
+ logger.info(s"Server created on $hostName:${server.getPort}")
+ } else {
+ logger.info(s"Server created on $hostName $bindAddress:${server.getPort}")
Review Comment:
```
NettyBlockTransferService: Server created on otherHost localhost:54718
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36984:
URL: https://github.com/apache/spark/pull/36984#discussion_r906611920
##########
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala:
##########
@@ -71,7 +71,7 @@ private[spark] abstract class RestSubmissionServer(
def start(): Int = {
val (server, boundPort) = Utils.startServiceOnPort[Server](requestedPort, doStart, masterConf)
_server = Some(server)
- logInfo(s"Started REST server for submitting applications on port $boundPort")
+ logInfo(s"Started REST server for submitting applications on $host with port $boundPort")
Review Comment:
**IPv4**
```
StandaloneRestServer: Started REST server for submitting applications on 172.16.0.31 with port 54511
```
**IPv6**
```
StandaloneRestServer: Started REST server for submitting applications on [0:0:0:0:0:0:0:1] with port 54566
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36984:
URL: https://github.com/apache/spark/pull/36984#issuecomment-1166280206
Rebased to the master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36984:
URL: https://github.com/apache/spark/pull/36984#discussion_r906611419
##########
common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java:
##########
@@ -149,8 +149,9 @@ protected void initChannel(SocketChannel ch) {
channelFuture = bootstrap.bind(address);
channelFuture.syncUninterruptibly();
- port = ((InetSocketAddress) channelFuture.channel().localAddress()).getPort();
- logger.debug("Shuffle server started on port: {}", port);
+ InetSocketAddress localAddress = (InetSocketAddress) channelFuture.channel().localAddress();
+ port = localAddress.getPort();
+ logger.debug("Shuffle server started on {} with port {}", localAddress.getHostString(), port);
Review Comment:
New logs look like the following.
```
TransportServer: Shuffle server started on 0:0:0:0:0:0:0:0 with port 54193
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36984:
URL: https://github.com/apache/spark/pull/36984#issuecomment-1166200759
All test passed except SparkR Linter failure which is irrelevant.
```
x Failed to parse Rd in histogram.Rd
ℹ there is no package called ‘ggplot2’
Caused by error in `loadNamespace()`:
! there is no package called ‘ggplot2’
Execution halted
------------------------------------------------
Jekyll 4.2.1 Please append `--trace` to the `build` command
for any additional information or backtrace.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36984:
URL: https://github.com/apache/spark/pull/36984#discussion_r906611920
##########
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala:
##########
@@ -71,7 +71,7 @@ private[spark] abstract class RestSubmissionServer(
def start(): Int = {
val (server, boundPort) = Utils.startServiceOnPort[Server](requestedPort, doStart, masterConf)
_server = Some(server)
- logInfo(s"Started REST server for submitting applications on port $boundPort")
+ logInfo(s"Started REST server for submitting applications on $host with port $boundPort")
Review Comment:
```
StandaloneRestServer: Started REST server for submitting applications on 172.16.0.31 with port 54511
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36984:
URL: https://github.com/apache/spark/pull/36984#discussion_r906612721
##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -79,7 +79,7 @@ private[spark] class NettyBlockTransferService(
server = createServer(serverBootstrap.toList)
appId = conf.getAppId
- logger.info(s"Server created on $hostName:${server.getPort}")
+ logger.info(s"Server created on $hostName $bindAddress:${server.getPort}")
Review Comment:
`hostName` could be different from `bindAddress`.
```
NettyBlockTransferService: Server created on otherHost localhost:54718
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
URL: https://github.com/apache/spark/pull/36984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36984: [SPARK-39594][CORE] Improve logs to show addresses in addition to ports
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36984:
URL: https://github.com/apache/spark/pull/36984#issuecomment-1167069520
Rebased to the master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org