You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2021/06/11 14:06:44 UTC

Re: Review Request 73403: RANGER-3274 : Adding non-existing roles and associating it at the time of new Role and Policy creation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73403/
-----------------------------------------------------------

(Updated June 11, 2021, 2:06 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-3274
    https://issues.apache.org/jira/browse/RANGER-3274


Repository: ranger


Description
-------

At the time of new Role creation we can associate it with the other roles also. Earlier we were only allowed to associate existing roles.
with this fix we will be able to allow non-existing roles.
Approach : At the time of new role creation, will be creating a non-existing role and associate it with a new role if any non-existing role is passed in association.
Similar changes done at the time of policy creation.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 4452676f5 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 6483bbe1d 
  security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 4c50d8176 
  security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 58267bc5b 


Diff: https://reviews.apache.org/r/73403/diff/4/


Testing
-------

Test cases 
Role created using curl request having nonexisting multiple sub roles.
Policy created using curl requests having nonexisting multiple roles.


Thanks,

Dineshkumar Yadav