You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Pavel Moravec <pm...@redhat.com> on 2014/07/02 15:16:53 UTC
Review Request 23231: [C++ client] AMQP 1.0 closing session without closing
receiver first marks further messages as redelivered
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23231/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Gordon Sim, and mick goulish.
Bugs: QPID-5866
https://issues.apache.org/jira/browse/QPID-5866
Repository: qpid
Description
-------
Closing a session must release all messages that have yet to be fetched.
Attached is one possible way how to do that: in ConnectionContext::endSession.
The added code is copy&paste from ConnectionContext::detach - isn't it worth having some inline routine for that?
Diffs
-----
/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1607260
Diff: https://reviews.apache.org/r/23231/diff/
Testing
-------
Manual & automated tests passed.
Thanks,
Pavel Moravec
Re: Review Request 23231: [C++ client] AMQP 1.0 closing session without
closing receiver first marks further messages as redelivered
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23231/#review47196
-----------------------------------------------------------
Ship it!
Ship It!
- Gordon Sim
On July 2, 2014, 1:16 p.m., Pavel Moravec wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23231/
> -----------------------------------------------------------
>
> (Updated July 2, 2014, 1:16 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, and mick goulish.
>
>
> Bugs: QPID-5866
> https://issues.apache.org/jira/browse/QPID-5866
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Closing a session must release all messages that have yet to be fetched.
>
> Attached is one possible way how to do that: in ConnectionContext::endSession.
>
> The added code is copy&paste from ConnectionContext::detach - isn't it worth having some inline routine for that?
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1607260
>
> Diff: https://reviews.apache.org/r/23231/diff/
>
>
> Testing
> -------
>
> Manual & automated tests passed.
>
>
> Thanks,
>
> Pavel Moravec
>
>