You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/08/17 07:22:29 UTC
Review Request 61709: Ambari should expose whether a service is able
to rolling-restart instead of hard coding service name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61709/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Jayush Luniya, Koji Sekiguchi, and Sumit Mohanty.
Bugs: AMBARI-21737
https://issues.apache.org/jira/browse/AMBARI-21737
Repository: ambari
Description
-------
Add a new property called rollingRestartAllowed to metainfo.xml Existing logic of client components are not removed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 0b0a5da2b0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java 764e394540
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java a8a9a0faef
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml f408ba38ac
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml d322adc47b
ambari-server/src/main/resources/properties.json 11ca7f678a
ambari-web/app/mappers/stack_service_mapper.js 8931066f76
ambari-web/app/models/stack_service_component.js eb6f2dbff7
Diff: https://reviews.apache.org/r/61709/diff/1/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:12 min
[INFO] Finished at: 2017-08-17T00:01:59-07:00
[INFO] Final Memory: 85M/962M
[INFO] ------------------------------------------------------------------------
Install ambari
Deploy HDP
Ensure no regression
Kafka brokers allow rolling restart
This property can be used for any other services which have components that are not clients but support rolling restart.
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 61709: Ambari should expose whether a service is
able to rolling-restart instead of hard coding service name
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61709/#review183449
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Aug. 17, 2017, 7:22 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61709/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2017, 7:22 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, Koji Sekiguchi, and Sumit Mohanty.
>
>
> Bugs: AMBARI-21737
> https://issues.apache.org/jira/browse/AMBARI-21737
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a new property called rollingRestartAllowed to metainfo.xml Existing logic of client components are not removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 0b0a5da2b0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java 764e394540
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java a8a9a0faef
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml f408ba38ac
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml d322adc47b
> ambari-server/src/main/resources/properties.json 11ca7f678a
> ambari-web/app/mappers/stack_service_mapper.js 8931066f76
> ambari-web/app/models/stack_service_component.js eb6f2dbff7
>
>
> Diff: https://reviews.apache.org/r/61709/diff/1/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:12 min
> [INFO] Finished at: 2017-08-17T00:01:59-07:00
> [INFO] Final Memory: 85M/962M
> [INFO] ------------------------------------------------------------------------
>
> Install ambari
> Deploy HDP
> Ensure no regression
> Kafka brokers allow rolling restart
>
> This property can be used for any other services which have components that are not clients but support rolling restart.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>