You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/05/02 12:59:50 UTC
[PR] MINOR: [Pytohn][Docs] Fix mention of default for coerce_timestamps keyword in reading Parquet [arrow]
jorisvandenbossche opened a new pull request, #41498:
URL: https://github.com/apache/arrow/pull/41498
### Rationale for this change
In the meantime we have updated the default for the `version` keyword from "1.0" to "2.4" and recently to "2.6", but this was not yet reflected in the description of the `coerce_timestamps` keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python][Docs] Fix mention of default for coerce_timestamps keyword in reading Parquet [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #41498:
URL: https://github.com/apache/arrow/pull/41498#issuecomment-2090454183
I see that the user guide is actually also outdated .. https://arrow.apache.org/docs/dev/python/parquet.html#storing-timestamps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python][Docs] Fix mention of default for coerce_timestamps keyword in reading Parquet [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41498:
URL: https://github.com/apache/arrow/pull/41498#issuecomment-2176987843
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 093efdaff3eae5958d2c201bc1b4622fc84e8938.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/26391388332) has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python][Docs] Fix mention of default for coerce_timestamps keyword in reading Parquet [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #41498:
URL: https://github.com/apache/arrow/pull/41498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python][Docs] Fix mention of default for coerce_timestamps keyword in reading Parquet [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41498:
URL: https://github.com/apache/arrow/pull/41498#discussion_r1588472910
##########
python/pyarrow/parquet/core.py:
##########
@@ -761,9 +761,9 @@ def _sanitize_table(table, new_schema, flavor):
by flavor argument. This take priority over the coerce_timestamps option.
coerce_timestamps : str, default None
Cast timestamps to a particular resolution. If omitted, defaults are chosen
- depending on `version`. By default, for ``version='1.0'`` (the default)
- and ``version='2.4'``, nanoseconds are cast to microseconds ('us'), while
- for other `version` values, they are written natively without loss
+ depending on `version`. For ``version='1.0'`` and ``version='2.4'``,
Review Comment:
Should we use ` `` ` for `version` too?
```suggestion
depending on ``version``. For ``version='1.0'`` and ``version='2.4'``,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Python][Docs] Fix mention of default for coerce_timestamps keyword in reading Parquet [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #41498:
URL: https://github.com/apache/arrow/pull/41498#discussion_r1644514933
##########
python/pyarrow/parquet/core.py:
##########
@@ -761,9 +761,9 @@ def _sanitize_table(table, new_schema, flavor):
by flavor argument. This take priority over the coerce_timestamps option.
coerce_timestamps : str, default None
Cast timestamps to a particular resolution. If omitted, defaults are chosen
- depending on `version`. By default, for ``version='1.0'`` (the default)
- and ``version='2.4'``, nanoseconds are cast to microseconds ('us'), while
- for other `version` values, they are written natively without loss
+ depending on `version`. For ``version='1.0'`` and ``version='2.4'``,
Review Comment:
Strictly speaking not, because in that case we are referring to the keyword, which uses single backticks following the numpydoc guidelines (although the difference is a bit ambiguous)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org