You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/07 13:20:15 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #590: Imp: modify codes by code review of gitee
codecov-commenter commented on pull request #590:
URL: https://github.com/apache/dubbo-go/pull/590#issuecomment-640217887
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=h1) Report
> Merging [#590](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4dac621139bba0ac998e6d2939c48430cc7bc07b&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `59.09%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #590 +/- ##
===========================================
- Coverage 67.39% 67.35% -0.05%
===========================================
Files 188 188
Lines 9849 9852 +3
===========================================
- Hits 6638 6636 -2
- Misses 2560 2565 +5
Partials 651 651
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <66.66%> (-11.36%)` | :arrow_down: |
| [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <68.75%> (-1.19%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.69% <0.00%> (-5.77%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <0.00%> (-2.50%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <0.00%> (-1.84%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/590/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=footer). Last update [4dac621...158ff81](https://codecov.io/gh/apache/dubbo-go/pull/590?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org