[PATCH] "Try 'svn revert --recursive' instead?" shouldn't be triggered if the user tried that

[David Glasser <gl...@mit.edu>]

The "Try 'svn revert --recursive' instead?" message in svn_cl__revert
can be triggered even if you're already typing that command.  (For a
recipe that reveals this, see the comment I just made on Issue 2466.)
That's kind of rude. This patch fixes that.

[[[
Don't suggest "svn revert --recursive" if we're already doing that.

* subversion/svn/revert-command.c
  (svn_cl__revert): Check opt_state->recursive before advising to use it.
]]]

-- 
David Glasser | glasser@mit.edu

Re: [PATCH] "Try 'svn revert --recursive' instead?" shouldn't be triggered if the user tried that

[Julian Foad <ju...@btopenworld.com>]

David Glasser wrote:
> The "Try 'svn revert --recursive' instead?" message in svn_cl__revert
> can be triggered even if you're already typing that command.  (For a
> recipe that reveals this, see the comment I just made on Issue 2466.)
> That's kind of rude. This patch fixes that.

Ah, yes, oops.  Committed in r20303.

> 
> [[[
> Don't suggest "svn revert --recursive" if we're already doing that.
> 
> * subversion/svn/revert-command.c

(The name of the file is "revert-cmd.c".  I fixed that.)

>  (svn_cl__revert): Check opt_state->recursive before advising to use it.
> ]]]

Many thanks for the patch.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org