[GitHub] [hbase] petersomogyi commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

[GitBox <gi...@apache.org>]

petersomogyi commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1063745933


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##########
@@ -107,6 +108,20 @@
 
   private static final Logger LOG = LoggerFactory.getLogger(TransitRegionStateProcedure.class);
 
+  public static final String FORCE_REGION_RETAINMENT = "hbase.master.scp.retain.assignment.force";
+
+  public static final boolean DEFAULT_FORCE_REGION_RETAINMENT = false;
+
+  public static final String FORCE_REGION_RETAINMENT_WAIT =
+    "hbase.master.scp.retain.assignment.force.wait";
+
+  public static final long DEFAULT_FORCE_REGION_RETAINMENT_WAIT = 500;

Review Comment:
   I first read this config as how long we should wait for this server to come online. However, the code uses this config to sleep for this period between checks, so the overall wait time is FORCE_REGION_RETAINMENT_WAIT * FORCE_REGION_RETAINMENT_RETRIES.
   
   From the operator's perspective, I think it is better to manage this with overall wait time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org