You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/10 18:23:41 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1747: sched: Rename note_add to sched_note_add
xiaoxiang781216 edited a comment on pull request #1747:
URL: https://github.com/apache/incubator-nuttx/pull/1747#issuecomment-690598441
> The is a huge breaking change, it a callout not a subsystem. If you want to have an internal implementation subsystem that is fine but you can not break the interface.
Why? This is an internal function expose to the public header files just a couples of days ago, please review the related patch again: https://github.com/apache/incubator-nuttx/pull/1520 To keep https://github.com/apache/incubator-nuttx/pull/1520 change as small as possible, I split the rename patch to here.
BTW, there is no external user yet. so why do you think this patch will make a huge breaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org