[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #1522:
URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426146539



##########
File path: gradle/validation/documentation-lint.gradle
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+configure(rootProject) {
+
+  task documentationLint {
+    group 'Verification'
+    description 'Verify all documentation'
+
+    dependsOn ':lucene:checkBrokenLinks'
+    dependsOn ':solr:checkBrokenLinks'
+  }
+}
+
+configure(subprojects.findAll { it.path in [':lucene', ':solr'] }) {
+
+  project.afterEvaluate {
+    task checkBrokenLinks(type: CheckBrokenLinksTask) {
+      docsDir = project.docroot
+      dependsOn subprojects.collect { prj ->

Review comment:
       I think that should just depend on the documentation task, so it can also check the index.html files and all other stuff.
   I think the python script will also find errors introduced by the markdown stuff. At least it did when I broke the ant task in #1477. 
   
   #1477 is ready for review, once it is erged you can test more.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org