[GitHub] [activemq] NikitaShupletsov commented on a diff in pull request #848: Feature/replica broker

[GitBox <gi...@apache.org>]

NikitaShupletsov commented on code in PR #848:
URL: https://github.com/apache/activemq/pull/848#discussion_r1065068052


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -2347,6 +2436,25 @@ public void processDispatchNotification(MessageDispatchNotification messageDispa
         Subscription sub = getMatchingSubscription(messageDispatchNotification);
         if (sub != null) {
             MessageReference message = getMatchingMessage(messageDispatchNotification);
+
+            pagedInMessagesLock.writeLock().lock();

Review Comment:
   it's method isn't used right now. it was introduced for pure master-slave feature that was deleted a long time ago. I noticed that the method wasn't working correctly, so I fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org