[GitHub] [cxf] reta commented on a change in pull request #572: CXF-8089: Build Comma Separated Values in url from Array/List Query Param

[GitBox <gi...@apache.org>]

reta commented on a change in pull request #572: CXF-8089: Build Comma Separated Values in url from Array/List Query Param
URL: https://github.com/apache/cxf/pull/572#discussion_r316473954
 
 

 ##########
 File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
 ##########
 @@ -119,7 +119,17 @@ public ClientProxyImpl(URI baseURI,
                            boolean isRoot,
                            boolean inheritHeaders,
                            Object... varValues) {
-        this(new LocalClientState(baseURI), loader, cri, isRoot, inheritHeaders, varValues);
+        this(baseURI, loader, cri, isRoot, inheritHeaders, Collections.emptyMap(), varValues);
 
 Review comment:
   Thanks a lot for review, @andymc12! The `Collections.emptyMap()` is actually backed by the constant, basically the only purpose of the method is to cast the generic parameters (this is implementation from `Collections`):
   ```
       public static final <K,V> Map<K,V> emptyMap() {
           return (Map<K,V>) EMPTY_MAP;
       }
   ```
   
   Using `null` is also possible, but is a bit risky since `ClientProxyImpl` has a number of overloaded constructors.
   
   Sounds good? Thanks a lot!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services