[GitHub] [ozone] sumitagrawl commented on a diff in pull request #4008: HDDS-7541. FSO recursive delete directory with hierarchy takes much time for cleanup

[GitBox <gi...@apache.org>]

sumitagrawl commented on code in PR #4008:
URL: https://github.com/apache/ozone/pull/4008#discussion_r1037907077


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestDirectoryDeletingServiceWithFSO.java:
##########
@@ -231,13 +231,14 @@ public void testDeleteWithLargeSubPathsThanBatchSize() throws Exception {
 
     assertSubPathsCount(dirDeletingService::getMovedFilesCount, 15);
     // 15 subDir + 3 parentDir
-    assertSubPathsCount(dirDeletingService::getMovedDirsCount, 18);
-    assertSubPathsCount(dirDeletingService::getDeletedDirsCount, 19);
+    // handled 5 move dir or file as capacity as recursive
+    assertSubPathsCount(dirDeletingService::getMovedDirsCount, 17);
+    assertSubPathsCount(dirDeletingService::getDeletedDirsCount, 25);

Review Comment:
   Fixed, after refactoring, I was check for dirDeleted which is passed as null, but proto class is having as empty string, added that check to fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org