You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/07/26 23:48:06 UTC

[GitHub] [solr] markrmiller commented on pull request #235: SOLR-15559 Small optimization in StrUtils.splitSmart()

markrmiller commented on pull request #235:
URL: https://github.com/apache/solr/pull/235#issuecomment-887102668


   Very nice. Not the only place someone favored a new StringBuilder over setLength(0) or did not size it. Adds up, especially with a util call like this that can happen in loops.
   
   CharBuffer and StringBuilder have sim perf with small data, but then CharBuffer pulls ahead, so that is also a winner.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org