[GitHub] [zeppelin] zjffdu commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3445: [ZEPPELIN-4263] Fixed cluster docker mode cannot exit the container of the remote interpreter
URL: https://github.com/apache/zeppelin/pull/3445#discussion_r325013103
 
 

 ##########
 File path: zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java
 ##########
 @@ -162,6 +162,8 @@ public String getInterpreterSettingName() {
   public void start(String userName) throws IOException {
     docker = DefaultDockerClient.builder().uri(URI.create(DOCKER_HOST)).build();
 
+    removeExistContainer(containerName);
 
 Review comment:
   Could you add comment here why need to remove exist container ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services