You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "steinsgateted (via GitHub)" <gi...@apache.org> on 2023/05/18 16:25:15 UTC
[GitHub] [yunikorn-core] steinsgateted opened a new pull request, #549: [YUNIKORN-1735] REST API for specific node
steinsgateted opened a new pull request, #549:
URL: https://github.com/apache/yunikorn-core/pull/549
### What is this PR for?
add a REST API:` /ws/v1/partition/%s/node/%s/`
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1735
### How should this be tested?
http://localhost:9080/ws/v1/partition/default/node/kind-worker
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #549: [YUNIKORN-1735] REST API for specific node
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #549:
URL: https://github.com/apache/yunikorn-core/pull/549#issuecomment-1553955761
unit test failures is not related re-running to see if the test is flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #549: [YUNIKORN-1735] REST API for specific node
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #549: [YUNIKORN-1735] REST API for specific node
URL: https://github.com/apache/yunikorn-core/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #549: [YUNIKORN-1735] REST API for specific node
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #549:
URL: https://github.com/apache/yunikorn-core/pull/549#issuecomment-1553957491
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/549?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#549](https://app.codecov.io/gh/apache/yunikorn-core/pull/549?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (44b2f39) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/943858560bf50c3d537f100b277e8706ce68480f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9438585) will **decrease** coverage by `0.02%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 74.97% 74.95% -0.02%
==========================================
Files 70 70
Lines 11374 11397 +23
==========================================
+ Hits 8528 8543 +15
- Misses 2545 2552 +7
- Partials 301 302 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `79.79% <66.66%> (-0.51%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org