You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/07/15 14:40:17 UTC
[GitHub] [jackrabbit-oak] kwin opened a new pull request, #623: OAK-9840: wait for all required MountInfoConfigs
kwin opened a new pull request, #623:
URL: https://github.com/apache/jackrabbit-oak/pull/623
also consider later configs by making the reference greedy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #623: OAK-9840: wait for all required MountInfoConfigs
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #623:
URL: https://github.com/apache/jackrabbit-oak/pull/623#discussion_r923201352
##########
oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/MountInfoProviderService.java:
##########
@@ -125,7 +126,7 @@ private void addMountInfoConfigFromProperties(Props mountInfoProps) {
}
}
- @Reference(cardinality = ReferenceCardinality.MULTIPLE)
+ @Reference(cardinality = ReferenceCardinality.MULTIPLE, policyOption = ReferencePolicyOption.GREEDY)
Review Comment:
Probably this was thought to be dynamic (not static) as it is threadsafe (CopyOnWriteArrayList) and leads to less reactivation of this service. Also dynamic makes the greedy part obsolete: https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#d0e30480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin merged pull request #623: OAK-9840: wait for all required MountInfoConfigs
Posted by GitBox <gi...@apache.org>.
kwin merged PR #623:
URL: https://github.com/apache/jackrabbit-oak/pull/623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] jelmini commented on pull request #623: OAK-9840: wait for all required MountInfoConfigs
Posted by GitBox <gi...@apache.org>.
jelmini commented on PR #623:
URL: https://github.com/apache/jackrabbit-oak/pull/623#issuecomment-1186926389
Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org