You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/24 06:45:11 UTC

[GitHub] [spark] dilipbiswal commented on a change in pull request #24442: [SPARK-27547][SQL] fix DataFrame self-join problems

dilipbiswal commented on a change in pull request #24442: [SPARK-27547][SQL] fix DataFrame self-join problems
URL: https://github.com/apache/spark/pull/24442#discussion_r277974738
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala
 ##########
 @@ -117,6 +117,57 @@ class DataFrameJoinSuite extends QueryTest with SharedSQLContext {
         .collect().toSeq)
   }
 
+  test("join - self join without manual alias") {
 
 Review comment:
   @cloud-fan Could we add some tests for nested columns ? In case of nested columns, do we need to carry more metadata ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org