You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/09/07 02:50:43 UTC

[GitHub] [incubator-druid] jon-wei opened a new pull request #8487: Add initial SQL support for non-expression sketch postaggs

jon-wei opened a new pull request #8487: Add initial SQL support for non-expression sketch postaggs
URL: https://github.com/apache/incubator-druid/pull/8487
 
 
   This PR adds support for using PostAggregators on Datasketches aggregators in SQL, by adding new SQL operators that accept quantile, HLL, and theta sketches.
   
   To support this, the SQL system has been updated to allow operators to be converted into non-expression-based PostAggregators. This is accomplished by adding a new `PostAggregatorVisitor` class and adding new variants of the existing RexNode conversion methods that accept a post agg visitor.
   
   This PR does not add support for all current sketch postaggregators (such as `DoublesSketchToCDFPostAggregator`) and the tuple sketch is currently not supported, I plan to  handle this in a follow on PR. 
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org