You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/02/21 13:25:30 UTC
[GitHub] [airflow] pankajastro opened a new pull request, #29657: Add `wait_for_completion` param in `RedshiftCreateClusterOperator`
pankajastro opened a new pull request, #29657:
URL: https://github.com/apache/airflow/pull/29657
Add `wait_for_completion` param in RedshiftCreateClusterOperator this will enable me to use a single operator to make a cluster in the available state
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29657: Add `wait_for_completion` param in `RedshiftCreateClusterOperator`
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29657:
URL: https://github.com/apache/airflow/pull/29657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajastro commented on a diff in pull request #29657: Add `wait_for_completion` param in `RedshiftCreateClusterOperator`
Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro commented on code in PR #29657:
URL: https://github.com/apache/airflow/pull/29657#discussion_r1114217431
##########
tests/providers/amazon/aws/operators/test_redshift_cluster.py:
##########
@@ -76,6 +77,10 @@ def test_create_single_node_cluster(self, mock_get_conn):
**params,
)
+ mock_get_conn.return_value.get_waiter.return_value.wait.assert_called_once_with(
Review Comment:
Added the test when wait_for_completion is False and I think it makes sense to have this test too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on a diff in pull request #29657: Add `wait_for_completion` param in `RedshiftCreateClusterOperator`
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #29657:
URL: https://github.com/apache/airflow/pull/29657#discussion_r1113524200
##########
tests/providers/amazon/aws/operators/test_redshift_cluster.py:
##########
@@ -76,6 +77,10 @@ def test_create_single_node_cluster(self, mock_get_conn):
**params,
)
+ mock_get_conn.return_value.get_waiter.return_value.wait.assert_called_once_with(
Review Comment:
We should test that the waiter is not called when `wait_for_completion` is `False`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org