You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <p....@ubik-ingenierie.com> on 2018/01/27 14:06:57 UTC
The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Hello,
I fixed in r1822407 the missing ADD_MODS on windows but there is still an
issue , on JAVA8 the ADD_MODS variable is wrongly updated
Also there is a difference between windows and *nix in the way we detect
java and use JAVA_HOME (on linux and not on windows)
--
Cordialement.
Philippe
Re: The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Posted by Philippe Mouawad <ph...@gmail.com>.
I think we should include a test that runs the shells as we didn’t trap the
issue with add_mods with our current tests.
Regards
On Saturday, January 27, 2018, Philippe Mouawad <ph...@gmail.com>
wrote:
>
>
> On Sat, Jan 27, 2018 at 4:18 PM, Felix Schumacher <felix.schumacher@
> internetallee.de> wrote:
>
>> Am 27.01.2018 um 15:55 schrieb Philippe Mouawad:
>>
>>> Hi Felix,
>>> I fixed it, the script was strange:
>>>
>>> - I don't understand this as variable does not exist : >>>>> IF
>>> "%variable:~0,2%"=="1." ( <<<<<
>>> - JAVAVER contains "1.X.X" so I have used : >>>>> IF
>>> "%JAVAVER:~1,2%"=="1."
>>> <<<<<<
>>>
>> Probably a mistake in the original commit and nobody used it with java 9.
>>
>> But I don't understand, why you changed :~0,2 to ~1,2? Does JAVAVER not
>> start with 1.?
>>
> Because there is a quote in JAVAVER:
> JAVAVER will be equal to "9.0.4" (quotes are part of the value)
> JAVAVER will be equal to "1.8.0_161" (quotes are part of the value)
>
>
>>
>> Felix
>>
>>
>>
>>> Regards
>>>
>>>
>>> On Sat, Jan 27, 2018 at 3:53 PM, Philippe Mouawad <
>>> philippe.mouawad@gmail.com> wrote:
>>>
>>> On Sat, Jan 27, 2018 at 3:31 PM, Felix Schumacher <felix.schumacher@
>>>> internetallee.de> wrote:
>>>>
>>>> Am 27.01.2018 um 15:06 schrieb Philippe Mouawad:
>>>>>
>>>>> Hello,
>>>>>> I fixed in r1822407 the missing ADD_MODS on windows but there is
>>>>>> still an
>>>>>> issue , on JAVA8 the ADD_MODS variable is wrongly updated
>>>>>>
>>>>>> Can you be more specific, what is wrong? Is this windows, only?
>>>>>
>>>>> Also there is a difference between windows and *nix in the way we
>>>>>> detect
>>>>>> java and use JAVA_HOME (on linux and not on windows)
>>>>>>
>>>>>> As far as I can see, we are not using JAVA_HOME under windows at all.
>>>>>
>>>>> Felix
>>>>>
>>>>>
>>>>>>
>>>> --
>>>> Cordialement.
>>>> Philippe Mouawad.
>>>>
>>>>
>>>>
>>>>
>>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Jan 27, 2018 at 4:18 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Am 27.01.2018 um 15:55 schrieb Philippe Mouawad:
>
>> Hi Felix,
>> I fixed it, the script was strange:
>>
>> - I don't understand this as variable does not exist : >>>>> IF
>> "%variable:~0,2%"=="1." ( <<<<<
>> - JAVAVER contains "1.X.X" so I have used : >>>>> IF
>> "%JAVAVER:~1,2%"=="1."
>> <<<<<<
>>
> Probably a mistake in the original commit and nobody used it with java 9.
>
> But I don't understand, why you changed :~0,2 to ~1,2? Does JAVAVER not
> start with 1.?
>
Because there is a quote in JAVAVER:
JAVAVER will be equal to "9.0.4" (quotes are part of the value)
JAVAVER will be equal to "1.8.0_161" (quotes are part of the value)
>
> Felix
>
>
>
>> Regards
>>
>>
>> On Sat, Jan 27, 2018 at 3:53 PM, Philippe Mouawad <
>> philippe.mouawad@gmail.com> wrote:
>>
>> On Sat, Jan 27, 2018 at 3:31 PM, Felix Schumacher <felix.schumacher@
>>> internetallee.de> wrote:
>>>
>>> Am 27.01.2018 um 15:06 schrieb Philippe Mouawad:
>>>>
>>>> Hello,
>>>>> I fixed in r1822407 the missing ADD_MODS on windows but there is still
>>>>> an
>>>>> issue , on JAVA8 the ADD_MODS variable is wrongly updated
>>>>>
>>>>> Can you be more specific, what is wrong? Is this windows, only?
>>>>
>>>> Also there is a difference between windows and *nix in the way we detect
>>>>> java and use JAVA_HOME (on linux and not on windows)
>>>>>
>>>>> As far as I can see, we are not using JAVA_HOME under windows at all.
>>>>
>>>> Felix
>>>>
>>>>
>>>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>>>
>>>
>>>
>>>
>>
>
--
Cordialement.
Philippe Mouawad.
Re: The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 27.01.2018 um 15:55 schrieb Philippe Mouawad:
> Hi Felix,
> I fixed it, the script was strange:
>
> - I don't understand this as variable does not exist : >>>>> IF
> "%variable:~0,2%"=="1." ( <<<<<
> - JAVAVER contains "1.X.X" so I have used : >>>>> IF "%JAVAVER:~1,2%"=="1."
> <<<<<<
Probably a mistake in the original commit and nobody used it with java 9.
But I don't understand, why you changed :~0,2 to ~1,2? Does JAVAVER not
start with 1.?
Felix
>
> Regards
>
>
> On Sat, Jan 27, 2018 at 3:53 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
>> On Sat, Jan 27, 2018 at 3:31 PM, Felix Schumacher <felix.schumacher@
>> internetallee.de> wrote:
>>
>>> Am 27.01.2018 um 15:06 schrieb Philippe Mouawad:
>>>
>>>> Hello,
>>>> I fixed in r1822407 the missing ADD_MODS on windows but there is still an
>>>> issue , on JAVA8 the ADD_MODS variable is wrongly updated
>>>>
>>> Can you be more specific, what is wrong? Is this windows, only?
>>>
>>>> Also there is a difference between windows and *nix in the way we detect
>>>> java and use JAVA_HOME (on linux and not on windows)
>>>>
>>> As far as I can see, we are not using JAVA_HOME under windows at all.
>>>
>>> Felix
>>>
>>>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>
Re: The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi Felix,
I fixed it, the script was strange:
- I don't understand this as variable does not exist : >>>>> IF
"%variable:~0,2%"=="1." ( <<<<<
- JAVAVER contains "1.X.X" so I have used : >>>>> IF "%JAVAVER:~1,2%"=="1."
<<<<<<
Regards
On Sat, Jan 27, 2018 at 3:53 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
>
> On Sat, Jan 27, 2018 at 3:31 PM, Felix Schumacher <felix.schumacher@
> internetallee.de> wrote:
>
>> Am 27.01.2018 um 15:06 schrieb Philippe Mouawad:
>>
>>> Hello,
>>> I fixed in r1822407 the missing ADD_MODS on windows but there is still an
>>> issue , on JAVA8 the ADD_MODS variable is wrongly updated
>>>
>> Can you be more specific, what is wrong? Is this windows, only?
>>
>>>
>>> Also there is a difference between windows and *nix in the way we detect
>>> java and use JAVA_HOME (on linux and not on windows)
>>>
>> As far as I can see, we are not using JAVA_HOME under windows at all.
>>
>> Felix
>>
>>>
>>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi Felix,
I fixed it, the script was strange:
- I don't understand this : "-IF "%variable:~0,2%"=="1." ("
On Sat, Jan 27, 2018 at 3:31 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Am 27.01.2018 um 15:06 schrieb Philippe Mouawad:
>
>> Hello,
>> I fixed in r1822407 the missing ADD_MODS on windows but there is still an
>> issue , on JAVA8 the ADD_MODS variable is wrongly updated
>>
> Can you be more specific, what is wrong? Is this windows, only?
>
>>
>> Also there is a difference between windows and *nix in the way we detect
>> java and use JAVA_HOME (on linux and not on windows)
>>
> As far as I can see, we are not using JAVA_HOME under windows at all.
>
> Felix
>
>>
>>
>
--
Cordialement.
Philippe Mouawad.
Re: The shell for Java 8 / 9 detection is broken on Windows 10 / Last
Java 8
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 27.01.2018 um 15:06 schrieb Philippe Mouawad:
> Hello,
> I fixed in r1822407 the missing ADD_MODS on windows but there is still an
> issue , on JAVA8 the ADD_MODS variable is wrongly updated
Can you be more specific, what is wrong? Is this windows, only?
>
> Also there is a difference between windows and *nix in the way we detect
> java and use JAVA_HOME (on linux and not on windows)
As far as I can see, we are not using JAVA_HOME under windows at all.
Felix
>