You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jonathanc-n (via GitHub)" <gi...@apache.org> on 2024/09/30 02:17:36 UTC
[D] FT.TAGVALS Implementation [kvrocks]
GitHub user jonathanc-n created a discussion: FT.TAGVALS Implementation
@PragmaTwice
For my implementation for FT.TAGVALS,
all information is here:
https://redis.io/docs/latest/commands/ft.tagvals/
I will create a map data structure under field info to keep track of unique tag values. Each unique tag value will have a reference to how many different times it is called and will be decremented or incremented whenever the same tag is added/removed. If it decrements to zero it will be removed. If multiple tags are being added/removed at the same time, the changes will be written in a batch.
What are your thoughts for this?
GitHub link: https://github.com/apache/kvrocks/discussions/2560
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
Re: [D] FT.TAGVALS Implementation Proposal [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
GitHub user PragmaTwice added a comment to the discussion: FT.TAGVALS Implementation Proposal
So how do you persist it to disk? What is its encoding format? How do you load it at initialization?
Is such tracking efficient? I think if users rarely perform this operation, then precise tracking will be unnecessary.
Also, before contributing to Kvrocks Search, please read:
- https://kvrocks.apache.org/community/kvrocks-search-index-encoding
- https://kvrocks.apache.org/blog/kqir-query-engine
GitHub link: https://github.com/apache/kvrocks/discussions/2560#discussioncomment-10792748
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
Re: [D] FT.TAGVALS Implementation Proposal [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
GitHub user PragmaTwice edited a comment on the discussion: FT.TAGVALS Implementation Proposal
So how do you persist it to disk? What is its encoding format? How do you load it at initialization of Kvrocks?
Is such tracking efficient? I think if users rarely perform this operation, then precise tracking will be unnecessary.
Also, before contributing to Kvrocks Search, please read:
- https://kvrocks.apache.org/community/kvrocks-search-index-encoding
- https://kvrocks.apache.org/blog/kqir-query-engine
GitHub link: https://github.com/apache/kvrocks/discussions/2560#discussioncomment-10792748
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
Re: [D] FT.TAGVALS Implementation Proposal [kvrocks]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
GitHub user jonathanc-n edited a discussion: FT.TAGVALS Implementation Proposal
@PragmaTwice
For my implementation for FT.TAGVALS,
all information is here:
https://redis.io/docs/latest/commands/ft.tagvals/
I will create a map data structure under field info to keep track of unique tag values. Each unique tag value will have a reference to how many different times it is called and will be decremented or incremented whenever the same tag is added/removed. If it decrements to zero it will be removed. If multiple tags are being added/removed at the same time, the changes will be written in a batch.
What are your thoughts for this?
GitHub link: https://github.com/apache/kvrocks/discussions/2560
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
Re: [D] FT.TAGVALS Implementation Proposal [kvrocks]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
GitHub user jonathanc-n added a comment to the discussion: FT.TAGVALS Implementation Proposal
I see thank you. I doubt users would perform the operation very often, do you think iterating through all the keys when the command is called would be better?
GitHub link: https://github.com/apache/kvrocks/discussions/2560#discussioncomment-10793226
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org