You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/11/12 11:57:19 UTC
[PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
zhengruifeng opened a new pull request, #48826:
URL: https://github.com/apache/spark/pull/48826
### What changes were proposed in this pull request?
Add a separate docker file for linter
### Why are the changes needed?
1, to centralize the installation of linter;
2, to spin it off the single docker;
### Does this PR introduce _any_ user-facing change?
no, infra-only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #48826:
URL: https://github.com/apache/spark/pull/48826#issuecomment-2470356592
also cc @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #48826:
URL: https://github.com/apache/spark/pull/48826#discussion_r1839308068
##########
.github/workflows/build_infra_images_cache.yml:
##########
@@ -74,3 +75,16 @@ jobs:
- name: Image digest (Documentation)
if: hashFiles('dev/spark-test-image/docs/Dockerfile') != ''
run: echo ${{ steps.docker_build_docs.outputs.digest }}
+ - name: Build and push (Linter)
+ if: hashFiles('dev/spark-test-image/lint/Dockerfile') != ''
+ id: docker_build_lint
+ uses: docker/build-push-action@v6
+ with:
+ context: ./dev/spark-test-image/docs/
Review Comment:
Should it be `./dev/spark-test-image/lint/` ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48826:
URL: https://github.com/apache/spark/pull/48826#issuecomment-2472684974
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #48826:
URL: https://github.com/apache/spark/pull/48826#discussion_r1838602547
##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -490,7 +490,7 @@ def __repr__(self) -> str:
# is sightly different:
# java.time.Duration only applies HOURS, MINUTES, SECONDS units,
# while Pandas applies all supported units.
- return pd.Timedelta(delta).isoformat() # type: ignore[attr-defined]
Review Comment:
Oh, good to know. I also didn't expect those kind of situations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #48826:
URL: https://github.com/apache/spark/pull/48826#discussion_r1839328911
##########
.github/workflows/build_infra_images_cache.yml:
##########
@@ -74,3 +75,16 @@ jobs:
- name: Image digest (Documentation)
if: hashFiles('dev/spark-test-image/docs/Dockerfile') != ''
run: echo ${{ steps.docker_build_docs.outputs.digest }}
+ - name: Build and push (Linter)
+ if: hashFiles('dev/spark-test-image/lint/Dockerfile') != ''
+ id: docker_build_lint
+ uses: docker/build-push-action@v6
+ with:
+ context: ./dev/spark-test-image/docs/
Review Comment:
good cache
##########
.github/workflows/build_infra_images_cache.yml:
##########
@@ -74,3 +75,16 @@ jobs:
- name: Image digest (Documentation)
if: hashFiles('dev/spark-test-image/docs/Dockerfile') != ''
run: echo ${{ steps.docker_build_docs.outputs.digest }}
+ - name: Build and push (Linter)
+ if: hashFiles('dev/spark-test-image/lint/Dockerfile') != ''
+ id: docker_build_lint
+ uses: docker/build-push-action@v6
+ with:
+ context: ./dev/spark-test-image/docs/
Review Comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #48826: [SPARK-50283][INFRA] Add a separate docker file for linter
URL: https://github.com/apache/spark/pull/48826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50283][INFRA] Add a separate docker file for linter [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #48826:
URL: https://github.com/apache/spark/pull/48826#discussion_r1837981823
##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -490,7 +490,7 @@ def __repr__(self) -> str:
# is sightly different:
# java.time.Duration only applies HOURS, MINUTES, SECONDS units,
# while Pandas applies all supported units.
- return pd.Timedelta(delta).isoformat() # type: ignore[attr-defined]
Review Comment:
it is surprising that the two `type: ignore` were caused by non-linter dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org