You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "apoorvmittal10 (via GitHub)" <gi...@apache.org> on 2024/09/09 18:43:44 UTC
Re: [PR] KAFKA-17400: Added share fetch purgatory for delaying share fetch requests [kafka]
apoorvmittal10 commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1750754052
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -560,88 +588,58 @@ void maybeProcessFetchQueue() {
maybeCompleteInitializationWithException(sharePartitionKey, shareFetchPartitionData.future, throwable);
return;
}
- // Fetch messages for the partition only if it is active.
- int partitionMaxBytes = shareFetchPartitionData.partitionMaxBytes.getOrDefault(topicIdPartition, 0);
- // Add the share partition to the list of partitions to be fetched only if we can
- // acquire the fetch lock on it.
- if (sharePartition.maybeAcquireFetchLock()) {
- // If the share partition is already at capacity, we should not attempt to fetch.
Review Comment:
Seems the merge has changed things a bit as previous initilization error of share partition is now now considered.
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -560,88 +588,58 @@ void maybeProcessFetchQueue() {
maybeCompleteInitializationWithException(sharePartitionKey, shareFetchPartitionData.future, throwable);
return;
}
- // Fetch messages for the partition only if it is active.
- int partitionMaxBytes = shareFetchPartitionData.partitionMaxBytes.getOrDefault(topicIdPartition, 0);
- // Add the share partition to the list of partitions to be fetched only if we can
- // acquire the fetch lock on it.
- if (sharePartition.maybeAcquireFetchLock()) {
- // If the share partition is already at capacity, we should not attempt to fetch.
Review Comment:
Seems the merge has changed things a bit as previous initilization error of share partition is now not considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org