[GitHub] [iceberg] amogh-jahagirdar commented on a change in pull request #4006: [Draft] Snapshot reference retention evaluation

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on a change in pull request #4006:
URL: https://github.com/apache/iceberg/pull/4006#discussion_r795117963



##########
File path: api/src/main/java/org/apache/iceberg/SnapshotRef.java
##########
@@ -139,7 +146,7 @@ public Builder maxRefAgeMs(Long value) {
     }
 
     public SnapshotRef build() {
-      return new SnapshotRef(snapshotId, type, minSnapshotsToKeep, maxSnapshotAgeMs, maxRefAgeMs);
+      return new SnapshotRef(snapshotId, type, minSnapshotsToKeep, maxSnapshotAgeMs, maxRefAgeMs, System.currentTimeMillis());

Review comment:
       I am doubting this is the right way to set a timestamp. We'll need to make sure this is accurate at the time we commit the metadata operation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org