[jira] [Commented] (TS-4448) Remove superflous \n from TSDebug()

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287752#comment-15287752 ] 

Leif Hedstrom commented on TS-4448:
-----------------------------------

There's also a number of places where we do this with Debug().

> Remove superflous \n from TSDebug()
> -----------------------------------
>
>                 Key: TS-4448
>                 URL: https://issues.apache.org/jira/browse/TS-4448
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Leif Hedstrom
>              Labels: newbie++
>             Fix For: 7.0.0
>
>
> In a number of places (see below), even in docs, we have trailing \n in TSDebug() statements. This is not necessary (albeit, harmless).
> {code}
> doc/developer-guide/debugging/debug-tags.en.rst:       TSDebug ("my-plugin", "Starting my-plugin at %d\n", the_time);
> doc/developer-guide/plugins/example-plugins/blacklist/index.en.rst:            TSDebug ("blacklist_plugin", "This event was unexpected: %d\n", );
> example/blacklist-1/blacklist-1.c:        TSDebug("blacklist-1", "blacklisting site: %s\n", sites[i]);
> example/blacklist-1/blacklist-1.c:        TSDebug("blacklist_plugin", "This event was unexpected: %d\n", event);
> example/hello/hello.c:  TSDebug("debug-hello", "Hello World!\n");
> example/redirect-1/redirect-1.c:  // TSDebug("redirect_init", "ip_deny is %ld\n", ip_deny);
> example/remap/remap.cc:  TSDebug("debug-remap", "TSPluginInit: Remap plugin started\n");
> example/session-1/session-1.c:    TSDebug("tag_session", "In the default case: event = %d\n", event);
> example/version/version.c:  TSDebug("debug-version-plugin", "Running in Apache Traffic Server: v%d.%d.%d\n", major_ts_version, minor_ts_version,
> plugins/experimental/background_fetch/background_fetch.cc:    TSDebug(PLUGIN_NAME, "Creating log name %s\n", log_name);
> plugins/experimental/background_fetch/background_fetch.cc:    TSDebug(PLUGIN_NAME, "BgFetchState.acquire(): ret = %d, url = %s\n", ret, url.c_str());
> plugins/experimental/hipes/hipes.cc:          TSDebug(PLUGIN_NAME, "Found _redirect flag in URL: %d\n", redirect_flag);
> plugins/experimental/stale_while_revalidate/stale_while_revalidate.c:    TSDebug(PLUGIN_NAME, "Plugin registration succeeded.\n");
> plugins/experimental/stale_while_revalidate/stale_while_revalidate.c:  TSDebug(PLUGIN_NAME, "Plugin Init Complete.\n");
> plugins/header_rewrite/conditions.cc:    //   TSDebug(PLUGIN_NAME, "Opened DBM file %s\n", _file.c_str());
> plugins/header_rewrite/header_rewrite.cc:    TSDebug(PLUGIN_NAME_DBG, "   Adding rule to hook=%s\n", TSHttpHookNameLookup(rule->get_hook()));
> plugins/header_rewrite/header_rewrite_test.cc:    fprintf(stdout, "TSDebug: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
> plugins/header_rewrite/ruleset.cc:    TSDebug(PLUGIN_NAME, "   Adding condition: %%{%s} with arg: %s\n", p.get_op().c_str(), p.get_arg().c_str());
> plugins/header_rewrite/ruleset.cc:    TSDebug(PLUGIN_NAME, "   Adding operator: %s(%s)\n", p.get_op().c_str(), p.get_arg().c_str());
> plugins/libloader/libloader.c:      TSDebug("libloader", " loaded %s\n", lib);
> proxy/InkAPI.cc:// e.g. TSDebug("plugin-cool", "Snoopy is a cool guy even after %d requests.\n", num_reqs);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)