You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2026/04/28 12:29:18 UTC

[PR] fix: stabilize flaky TestCollectWithPartialClosedSegments and fit flaky-test in 50min [skywalking-banyandb]

hanahmily opened a new pull request, #1100:
URL: https://github.com/apache/skywalking-banyandb/pull/1100

   ### Fix flaky `TestCollectWithPartialClosedSegments` and flaky-test workflow timeout
   
   - [x] Add a unit test to verify that the fix works.
   - [x] Explain briefly why the bug exists and how to fix it.
   
   **Why the bug exists**
   
   `TestCollectWithPartialClosedSegments` configured `SegmentIdleTimeout: 100ms` and backdated the target segments' `lastAccessed` by `-1h`. On slow CI runners, wall-clock variance between segment creation and the idle check meant *all* segments — including ones the test wanted left open — could exceed the 100ms idle window, so the assertion on partially-closed state flaked.
   
   Separately, the hourly `Flaky Tests` workflow ran with Ginkgo `--repeat 3`, which routinely overran the 50-minute job timeout and was cancelled before producing useful signal.
   
   **How it's fixed**
   
   - Raise `SegmentIdleTimeout` to `1h` and backdate the targeted segments' `lastAccessed` to `-2h`. Now only the segments the test explicitly marks as idle qualify, regardless of CI scheduling jitter.
   - Set `--repeat 0` in `.github/workflows/flaky-test.yml` so the run fits inside the 50-minute timeout.
   
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: stabilize flaky TestCollectWithPartialClosedSegments and fit flaky-test in 50min [skywalking-banyandb]

Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #1100:
URL: https://github.com/apache/skywalking-banyandb/pull/1100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org