You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/11/08 04:23:41 UTC

Review Request 53566: GEODE-2078: Fix manifest classpath

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53566/
-----------------------------------------------------------

Review request for geode, Mark Bretl and Dan Smith.


Repository: geode


Description
-------

The manifest classpath for *-dependencies.jar was pulling in
dependencies from geode-pulse and geode-web-api. Filter out those
projects before collecting the jars.


Diffs
-----

  geode-assembly/build.gradle cc2518b834fee59d8c7fc91233f2206c6a379c96 

Diff: https://reviews.apache.org/r/53566/diff/


Testing
-------


Thanks,

Anthony Baker


Re: Review Request 53566: GEODE-2078: Fix manifest classpath

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53566/#review155360
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On Nov. 8, 2016, 4:23 a.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53566/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 4:23 a.m.)
> 
> 
> Review request for geode, Mark Bretl and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The manifest classpath for *-dependencies.jar was pulling in
> dependencies from geode-pulse and geode-web-api. Filter out those
> projects before collecting the jars.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle cc2518b834fee59d8c7fc91233f2206c6a379c96 
> 
> Diff: https://reviews.apache.org/r/53566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>


Re: Review Request 53566: GEODE-2078: Fix manifest classpath

Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53566/#review155358
-----------------------------------------------------------


Ship it!




Ship It!

- Mark Bretl


On Nov. 7, 2016, 8:23 p.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53566/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 8:23 p.m.)
> 
> 
> Review request for geode, Mark Bretl and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The manifest classpath for *-dependencies.jar was pulling in
> dependencies from geode-pulse and geode-web-api. Filter out those
> projects before collecting the jars.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle cc2518b834fee59d8c7fc91233f2206c6a379c96 
> 
> Diff: https://reviews.apache.org/r/53566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>