You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2018/06/15 02:07:16 UTC

Review Request 67606: Allow for unbundled libevent cmake builds.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.


Bugs: MESOS-8998
    https://issues.apache.org/jira/browse/MESOS-8998


Repository: mesos


Description
-------

Allow for unbundled libevent cmake builds.


Diffs
-----

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
  3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 


Diff: https://reviews.apache.org/r/67606/diff/1/


Testing
-------

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```


Thanks,

Till Toenshoff

Re: Review Request 67606: Allowed for unbundled libevent cmake builds.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204891
-----------------------------------------------------------



PASS: Mesos patch 67606 was successfully built and tested.

Reviews applied: `['67606']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606

- Mesos Reviewbot Windows


On June 15, 2018, 7:06 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds the option UNBUNDLED_LIBEVENT for using an installed libevent
> instead of the bundled version. That option is set towards
> TRUE by default on macOS, FALSE otherwise. Additionally adds the flag
> LIBEVENT_ROOT_DIR for specifying the path to an unbundled libevent.
> Updates the cmake documentation with the above flags.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review205331
-----------------------------------------------------------



PASS: Mesos patch 67606 was successfully built and tested.

Reviews applied: `['67606']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606

- Mesos Reviewbot Windows


On June 25, 2018, 7:01 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 7:01 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/FindLIBEVENT.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/5/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review205286
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67606']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606

Relevant logs:

- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606/logs/stout-tests-cmake-stdout.log):

```
       "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (5) ->
       (CustomBuild target) -> 
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
       "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (10) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (6) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

    1 Warning(s)
    5 Error(s)

Time Elapsed 00:03:17.76
```

- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606/logs/libprocess-tests-cmake-stdout.log):

```
       (CustomBuild target) -> 
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (11) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target) (8) ->
       "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (18) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target) (8) ->
       "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (19) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

    113 Warning(s)
    5 Error(s)

Time Elapsed 00:03:29.71
```

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606/logs/mesos-tests-cmake-stdout.log):

```
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (9) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (16) ->
       "D:\DCOS\mesos\src\slave\containerizer\mesos\mesos-containerizer.vcxproj" (default target) (22) ->
       "D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj" (default target) (32) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\mesos.vcxproj" (default target) (17) ->
       "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (25) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (4) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]

    1 Warning(s)
    7 Error(s)

Time Elapsed 00:00:20.19
```

- Mesos Reviewbot Windows


On June 25, 2018, 2:01 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 2:01 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/FindLIBEVENT.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/5/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Till Toenshoff <to...@me.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/
-----------------------------------------------------------

(Updated June 25, 2018, 2:01 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.


Changes
-------

Addressed comment.


Bugs: MESOS-8998
    https://issues.apache.org/jira/browse/MESOS-8998


Repository: mesos


Description
-------

Allow for unbundled libevent cmake builds.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
  3rdparty/cmake/FindLIBEVENT.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
  docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 


Diff: https://reviews.apache.org/r/67606/diff/5/

Changes: https://reviews.apache.org/r/67606/diff/4-5/


Testing
-------

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```


Thanks,

Till Toenshoff

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204908
-----------------------------------------------------------



PASS: Mesos patch 67606 was successfully built and tested.

Reviews applied: `['67606']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606

- Mesos Reviewbot Windows


On June 17, 2018, 1:33 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 17, 2018, 1:33 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/4/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204909
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67606]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 17, 2018, 10:33 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 17, 2018, 10:33 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/4/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Till Toenshoff <to...@me.com>.


> On June 18, 2018, 9:17 a.m., Benjamin Bannier wrote:
> > 3rdparty/cmake/Findlibevent.cmake
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/67606/diff/4/?file=2041221#file2041221line1>
> >
> >     This file should be called `3rdparty/cmake/FindLIBEVENT.cmake` (package name all UPPERCASE). This is the usual convention, see e.g., cmake upstream.

Interesting - is there a ticket for this techdebt (on the other FindXXX components)?


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204911
-----------------------------------------------------------


On June 25, 2018, 2:01 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 2:01 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/FindLIBEVENT.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/5/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Benjamin Bannier <be...@mesosphere.io>.


> On June 18, 2018, 11:17 a.m., Benjamin Bannier wrote:
> > 3rdparty/cmake/Findlibevent.cmake
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/67606/diff/4/?file=2041221#file2041221line1>
> >
> >     This file should be called `3rdparty/cmake/FindLIBEVENT.cmake` (package name all UPPERCASE). This is the usual convention, see e.g., cmake upstream.
> 
> Till Toenshoff wrote:
>     Interesting - is there a ticket for this techdebt (on the other FindXXX components)?

https://reviews.apache.org/r/67738/


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204911
-----------------------------------------------------------


On June 25, 2018, 4:01 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 4:01 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/FindLIBEVENT.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/5/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204911
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for this Till, LGTM.

I mention some of my grievances with `find_package_helper` below. It can e.g., lead to inconsistent results, or ignore arguments to `find_package` which users likely expect to change behavior.


3rdparty/cmake/Findlibevent.cmake
Lines 1 (patched)
<https://reviews.apache.org/r/67606/#comment287706>

    This file should be called `3rdparty/cmake/FindLIBEVENT.cmake` (package name all UPPERCASE). This is the usual convention, see e.g., cmake upstream.



3rdparty/cmake/Findlibevent.cmake
Lines 41 (patched)
<https://reviews.apache.org/r/67606/#comment287710>

    Note `find_package` interprets these paths only as `HINTS`, so that e.g., even if `LIBEVENT_ROOT_DIR` does not exist we might still find an installation somewhere else in the system.
    
    This is tech debt in `find_package`, not an issue we should address here.



3rdparty/cmake/Findlibevent.cmake
Lines 51 (patched)
<https://reviews.apache.org/r/67606/#comment287708>

    I was about to suggest to use `find_package_handle_standard_args` here, but `find_package_helper` implements part of that in suprising ways (e.g., due to the way `find_package_helper` is implemented, even when calling `find_package(LIBEVENT)` it becomes `REQUIRED`.
    
    I created https://issues.apache.org/jira/browse/MESOS-9005 to track this.


- Benjamin Bannier


On June 17, 2018, 10:33 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 17, 2018, 10:33 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/4/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Till Toenshoff <to...@me.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/
-----------------------------------------------------------

(Updated June 17, 2018, 8:33 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.


Changes
-------

Addressed comment.


Summary (updated)
-----------------

Allow for unbundled libevent cmake builds.


Bugs: MESOS-8998
    https://issues.apache.org/jira/browse/MESOS-8998


Repository: mesos


Description (updated)
-------

Allow for unbundled libevent cmake builds.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
  3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
  docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 


Diff: https://reviews.apache.org/r/67606/diff/3/

Changes: https://reviews.apache.org/r/67606/diff/2-3/


Testing
-------

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```


Thanks,

Till Toenshoff

Re: Review Request 67606: Allowed for unbundled libevent cmake builds.

Posted by Till Toenshoff <to...@me.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/
-----------------------------------------------------------

(Updated June 16, 2018, 2:06 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, and Jan Schlicht.


Changes
-------

Added macOS detection, added LIBEVENT_ROOT_DIR flag, updated cmake documentation.


Summary (updated)
-----------------

Allowed for unbundled libevent cmake builds.


Bugs: MESOS-8998
    https://issues.apache.org/jira/browse/MESOS-8998


Repository: mesos


Description (updated)
-------

Adds the option UNBUNDLED_LIBEVENT for using an installed libevent
instead of the bundled version. That option is set towards
TRUE by default on macOS, FALSE otherwise. Additionally adds the flag
LIBEVENT_ROOT_DIR for specifying the path to an unbundled libevent.
Updates the cmake documentation with the above flags.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
  3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
  cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
  docs/configuration/cmake.md 74abe65507d251ffb9cbae31a6fa18eb0d76e79b 


Diff: https://reviews.apache.org/r/67606/diff/2/

Changes: https://reviews.apache.org/r/67606/diff/1-2/


Testing
-------

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```

```
$ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
$ cmake --build . --target tests -- -j6

$ otool -L 3rdparty/libprocess/src/libprocess.dylib
libprocess.dylib:
	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
```


Thanks,

Till Toenshoff

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204888
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67606]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 2:07 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 2:07 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204885
-----------------------------------------------------------


Fix it, then Ship it!




Seems reasonable. Going forward, we should be consistent with this patch when adding options to `UNBUNDLE` specific dependencies.


3rdparty/cmake/Findlibevent.cmake
Lines 36-45 (patched)
<https://reviews.apache.org/r/67606/#comment287681>

    Just a suggestion, but if you wanted this could be:
    
    ```
    set(LIBEVENT_LIBRARY_NAMES
      event
      event_pthreads)
      
    if (ENABLE_SSL)
      list(APPEND LIBEVENT_LIBRARY_NAMES event_openssl)
    endif()
    ```


- Andrew Schwartzmeyer


On June 14, 2018, 7:07 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 7:07 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67606/#review204818
-----------------------------------------------------------



PASS: Mesos patch 67606 was successfully built and tested.

Reviews applied: `['67606']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67606

- Mesos Reviewbot Windows


On June 15, 2018, 2:07 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67606/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 2:07 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
> 
> 
> Bugs: MESOS-8998
>     https://issues.apache.org/jira/browse/MESOS-8998
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow for unbundled libevent cmake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   3rdparty/cmake/Findlibevent.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
> 
> 
> Diff: https://reviews.apache.org/r/67606/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/libevent-2.1.5-beta/src/libevent-2.1.5-beta-build/lib/libevent.2.1.5.dylib (compatibility version 2.1.5, current version 0.0.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> ```
> $ cmake .. -DENABLE_LIBEVENT=TRUE -DENABLE_SSL=TRUE -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DUNBUNDLED_LIBEVENT=TRUE
> $ cmake --build . --target tests -- -j6
> 
> $ otool -L 3rdparty/libprocess/src/libprocess.dylib
> libprocess.dylib:
> 	@rpath/libprocess.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/apr/libexec/lib/libapr-1.0.dylib (compatibility version 7.0.0, current version 7.3.0)
> 	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/glog-0.3.3/src/glog-0.3.3-build/lib/libglog.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/Users/till/Development/mesos/build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0-build/libprotobuf.dylib (compatibility version 0.0.0, current version 0.0.0)
> 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
> 	/usr/local/opt/subversion/lib/libsvn_delta-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_diff-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/subversion/lib/libsvn_subr-1.0.dylib (compatibility version 1.0.0, current version 1.0.0)
> 	/usr/local/opt/libevent/lib/libevent_openssl-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/local/opt/libevent/lib/libevent_pthreads-2.0.5.dylib (compatibility version 7.0.0, current version 7.9.0)
> 	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.3)
> 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>