You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/09 17:53:36 UTC
[GitHub] markusthoemmes commented on a change in pull request #3165: Throttle log messages when rescheduling containers (update)
markusthoemmes commented on a change in pull request #3165: Throttle log messages when rescheduling containers (update)
URL: https://github.com/apache/incubator-openwhisk/pull/3165#discussion_r160478993
##########
File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##########
@@ -71,6 +71,8 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
var freePool = immutable.Map.empty[ActorRef, ContainerData]
var busyPool = immutable.Map.empty[ActorRef, ContainerData]
var prewarmedPool = immutable.Map.empty[ActorRef, ContainerData]
+ var lastRetryLog: Option[Long] = None
+ val logMessageInterval = 10000;
Review comment:
Can we use `FiniteDuration` here and work with higher level abstractions (`Instant`) instead of `Long`s?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services