You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/08/22 17:34:36 UTC

[GitHub] [struts] fp024 opened a new pull request, #589: @Before and @After related question in StrutsJUnit4TestCase class

fp024 opened a new pull request, #589:
URL: https://github.com/apache/struts/pull/589

   Hello.
   
   StrutsJUnit4TestCase class is not using JUnit4's @Before, @After.
   
   It works because JUnit4 doesn't even check the package name, it only checks the annotation name.
    
   But semantically, I think it's correct to use JUnit4's annotations.
   
   There is no issue tab page, so I made a Pull Request.
   
   Thanks you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] fp024 commented on pull request #589: @Before and @After related question in StrutsJUnit4TestCase class

Posted by GitBox <gi...@apache.org>.
fp024 commented on PR #589:
URL: https://github.com/apache/struts/pull/589#issuecomment-1222744706

   ![commit-message-issue](https://user-images.githubusercontent.com/42864970/185987882-6df5bea8-a204-474c-a09b-a99354a42535.png)
   
   Github parses the Commit Message strangely, so I'll close it.
   
   I'm sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] fp024 closed pull request #589: @Before and @After related question in StrutsJUnit4TestCase class

Posted by GitBox <gi...@apache.org>.
fp024 closed pull request #589: @Before and @After related question in StrutsJUnit4TestCase class
URL: https://github.com/apache/struts/pull/589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org