You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by km...@rockwellcollins.com on 2011/03/02 16:40:44 UTC
Re: [PATCH] fix for issue #3789 log -g regression in r1028108
"C. Michael Pilato" <cm...@collab.net> wrote on 01/28/2011 01:44:26 PM:
> Subject: Re: [PATCH] fix for issue #3789 log -g regression in r1028108
>
> On 01/26/2011 05:59 PM, Kevin Radke wrote:
> > This also needs a back-port to the 1.6.x branch.
> >
> > [[[
> > Fix issue #3789: Correctly ignore missing locations when a renamed
file
> > has more than MAX_OPEN_HISTORIES.
> >
> > * subversion/libsvn_repos/log.c
> > (get_path_histories): Ignore more bogus repository locations to
restore
> > pre-1.6.15 log -g behavior. This fixes
> client chunk
> > errors introduced by r1028108.
> > ]]]
>
> Committed this in r1064839 with tweaks to the log message. (Rather than
> open a new issue, I just reopened issue 3270). Will propose for
backport to
> 1.6.x, too. Thanks, Kevin.
Was this ever proposed for backport? (Or am I just missing it in STATUS?)
http://svn.apache.org/viewvc/subversion/branches/1.6.x/STATUS?view=markup
This does fix a regression introduced with 1.6.15...
Thanks!
Kevin R.
Re: [PATCH] fix for issue #3789 log -g regression in r1028108
Posted by km...@rockwellcollins.com.
Paul Burba <pt...@gmail.com> wrote on 03/02/2011 10:10:40 AM:
> On Wed, Mar 2, 2011 at 10:44 AM, C. Michael Pilato
> <cm...@collab.net> wrote:
> > On 03/02/2011 10:40 AM, kmradke@rockwellcollins.com wrote:
> >> "C. Michael Pilato" <cm...@collab.net> wrote on 01/28/2011
01:44:26 PM:
> >>> Subject: Re: [PATCH] fix for issue #3789 log -g regression in
r1028108
> >>>
> >>> On 01/26/2011 05:59 PM, Kevin Radke wrote:
> >>> > This also needs a back-port to the 1.6.x branch.
> >>> >
> >>> > [[[
> >>> > Fix issue #3789: Correctly ignore missing locations when a
> renamed file
> >>> > has more than MAX_OPEN_HISTORIES.
> >>> >
> >>> > * subversion/libsvn_repos/log.c
> >>> > (get_path_histories): Ignore more bogus repository
> locations to restore
> >>> > pre-1.6.15 log -g behavior. This fixes
> >>> client chunk
> >>> > errors introduced by r1028108.
> >>> > ]]]
> >>>
> >>> Committed this in r1064839 with tweaks to the log message. (Rather
than
> >>> open a new issue, I just reopened issue 3270). Will propose for
> backport to
> >>> 1.6.x, too. Thanks, Kevin.
> >>
> >> Was this ever proposed for backport? (Or am I just missing it in
STATUS?)
> >>
> >>
http://svn.apache.org/viewvc/subversion/branches/1.6.x/STATUS?view=markup
> >>
> >> This does fix a regression introduced with 1.6.15...
> >
> > Pretty confident that it did. I believe it's the "More fixes for
issue
> > #3270" item in CHANGES on the 1.6.x branch.
>
> Scratch "pretty confident" and insert "certain":
>
> http://svn.apache.org/viewvc?view=revision&revision=1072344
Excellent. Thanks for double checking this. (And thanks for not slapping
my hand too hard for not looking in the CHANGES file... :))
Kevin R.
Re: [PATCH] fix for issue #3789 log -g regression in r1028108
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Mar 2, 2011 at 10:44 AM, C. Michael Pilato <cm...@collab.net> wrote:
> On 03/02/2011 10:40 AM, kmradke@rockwellcollins.com wrote:
>> "C. Michael Pilato" <cm...@collab.net> wrote on 01/28/2011 01:44:26 PM:
>>> Subject: Re: [PATCH] fix for issue #3789 log -g regression in r1028108
>>>
>>> On 01/26/2011 05:59 PM, Kevin Radke wrote:
>>> > This also needs a back-port to the 1.6.x branch.
>>> >
>>> > [[[
>>> > Fix issue #3789: Correctly ignore missing locations when a renamed file
>>> > has more than MAX_OPEN_HISTORIES.
>>> >
>>> > * subversion/libsvn_repos/log.c
>>> > (get_path_histories): Ignore more bogus repository locations to restore
>>> > pre-1.6.15 log -g behavior. This fixes
>>> client chunk
>>> > errors introduced by r1028108.
>>> > ]]]
>>>
>>> Committed this in r1064839 with tweaks to the log message. (Rather than
>>> open a new issue, I just reopened issue 3270). Will propose for backport to
>>> 1.6.x, too. Thanks, Kevin.
>>
>> Was this ever proposed for backport? (Or am I just missing it in STATUS?)
>>
>> http://svn.apache.org/viewvc/subversion/branches/1.6.x/STATUS?view=markup
>>
>> This does fix a regression introduced with 1.6.15...
>
> Pretty confident that it did. I believe it's the "More fixes for issue
> #3270" item in CHANGES on the 1.6.x branch.
Scratch "pretty confident" and insert "certain":
http://svn.apache.org/viewvc?view=revision&revision=1072344
Paul
Re: [PATCH] fix for issue #3789 log -g regression in r1028108
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 03/02/2011 10:40 AM, kmradke@rockwellcollins.com wrote:
> "C. Michael Pilato" <cm...@collab.net> wrote on 01/28/2011 01:44:26 PM:
>> Subject: Re: [PATCH] fix for issue #3789 log -g regression in r1028108
>>
>> On 01/26/2011 05:59 PM, Kevin Radke wrote:
>> > This also needs a back-port to the 1.6.x branch.
>> >
>> > [[[
>> > Fix issue #3789: Correctly ignore missing locations when a renamed file
>> > has more than MAX_OPEN_HISTORIES.
>> >
>> > * subversion/libsvn_repos/log.c
>> > (get_path_histories): Ignore more bogus repository locations to restore
>> > pre-1.6.15 log -g behavior. This fixes
>> client chunk
>> > errors introduced by r1028108.
>> > ]]]
>>
>> Committed this in r1064839 with tweaks to the log message. (Rather than
>> open a new issue, I just reopened issue 3270). Will propose for backport to
>> 1.6.x, too. Thanks, Kevin.
>
> Was this ever proposed for backport? (Or am I just missing it in STATUS?)
>
> http://svn.apache.org/viewvc/subversion/branches/1.6.x/STATUS?view=markup
>
> This does fix a regression introduced with 1.6.15...
Pretty confident that it did. I believe it's the "More fixes for issue
#3270" item in CHANGES on the 1.6.x branch.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand