Re: [PR] Fix all problems Kaxil mentioned [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #53506:
URL: https://github.com/apache/airflow/pull/53506#discussion_r2217386912


##########
shared/logging/src/airflow_shared/__init__.py:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)

Review Comment:
   We can try to re remove it actually. It was more of a habit taken from providers. There providers shared "airflow" namespace and since we had `__init__.py` in "airflow" - it had to use legacy and there were problems with discovery and IDEs when we mixed implicit and legacy packages as sub-packages (also as far as I remember it was not recommended in docs). 
   
   But yeah - in this case we can probably remove it from "airflow_shared" as it is a different namespace than "airflow" so there should be no problem. Let me try it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org