[jira] [Commented] (NIFI-5142) If funnel is made both the source and destination of a connection, connection cannot be removed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461500#comment-16461500 ] 

ASF GitHub Bot commented on NIFI-5142:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2669

    NIFI-5142: Do not allow a connection's destination to be changed to a…

    … funnel if the source is the same funnel. Also fixed some typos in StandardFunnel
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5142

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2669
    
----
commit bb9b0a75a737db17e06ff099c6ff2693aada9ca1
Author: Mark Payne <ma...@...>
Date:   2018-05-02T19:01:15Z

    NIFI-5142: Do not allow a connection's destination to be changed to a funnel if the source is the same funnel. Also fixed some typos in StandardFunnel

----


> If funnel is made both the source and destination of a connection, connection cannot be removed
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-5142
>                 URL: https://issues.apache.org/jira/browse/NIFI-5142
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.7.0
>
>
> To replicate, follow these steps:
> 1) Add a Funnel
> 2) Add an Output Port
> 3) Connect the Funnel to the Output Port
> 4) Add a bend point to the Connection (to help with the next step)
> 5) Attempt to change the target of the Connection to the Funnel (creating a self-loop)
> 6) An error is reported as expected
> 7) At this point, it is impossible to directly remove that Connection. Something appears to be in a bad state.
> 8) However, if you attempt to remove the Funnel the framework will implicitly removes all outgoing Connections. Possibly due to the bad state mentioned in the previous step, the Connection is not removed and remains in the flow.xml.gz even though the source of the Connection is removed. These leaves the flow.xml.gz with a Connection with a missing source element.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)